Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Unified Diff: content/browser/loader/navigation_url_loader_network_service.cc

Issue 2902653002: Get main frame and subframe AppCache loads to work. (Closed)
Patch Set: Fix compile failures Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/loader/navigation_url_loader_network_service.cc
diff --git a/content/browser/loader/navigation_url_loader_network_service.cc b/content/browser/loader/navigation_url_loader_network_service.cc
index f484182c77a6da1dc5bcdbfd8f230265fb458370..c3d6815ac0e209e97e0c3950b74fd76bc24d165d 100644
--- a/content/browser/loader/navigation_url_loader_network_service.cc
+++ b/content/browser/loader/navigation_url_loader_network_service.cc
@@ -9,6 +9,7 @@
#include "base/memory/ptr_util.h"
#include "base/trace_event/trace_event.h"
#include "content/browser/appcache/appcache_navigation_handle.h"
+#include "content/browser/appcache/appcache_url_loader_factory.h"
#include "content/browser/blob_storage/chrome_blob_storage_context.h"
#include "content/browser/frame_host/frame_tree_node.h"
#include "content/browser/frame_host/navigation_request_info.h"
@@ -129,7 +130,11 @@ class NavigationURLLoaderNetworkService::URLLoaderRequestController {
}
if (appcache_handle_core) {
- // TODO: add appcache code here.
+ std::unique_ptr<URLLoaderRequestHandler> appcache_handler =
+ AppCacheURLLoaderFactory::CreateRequestHandler(
michaeln 2017/06/02 01:17:59 I'd vote to maintain as much symmetry with S/W as
ananta 2017/06/03 01:55:55 Done.
+ appcache_handle_core, url_loader_factory_getter.get());
+ if (appcache_handler)
+ handlers_.push_back(std::move(appcache_handler));
}
DCHECK(!network_factory_);

Powered by Google App Engine
This is Rietveld 408576698