Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Unified Diff: content/browser/url_loader_factory_getter.cc

Issue 2902653002: Get main frame and subframe AppCache loads to work. (Closed)
Patch Set: Add comments and helper functions Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/url_loader_factory_getter.cc
diff --git a/content/browser/url_loader_factory_getter.cc b/content/browser/url_loader_factory_getter.cc
index 611cef7d8a05d2a61ca52840ec0632e01e3b0c40..a6fdb1c94f80c101b75ddb8e442d43b2f3235c56 100644
--- a/content/browser/url_loader_factory_getter.cc
+++ b/content/browser/url_loader_factory_getter.cc
@@ -5,7 +5,6 @@
#include "content/browser/url_loader_factory_getter.h"
#include "base/bind.h"
-#include "content/browser/appcache/appcache_url_loader_factory.h"
#include "content/browser/storage_partition_impl.h"
#include "content/common/network_service.mojom.h"
@@ -21,9 +20,7 @@ void URLLoaderFactoryGetter::Initialize(StoragePartitionImpl* partition) {
BrowserThread::PostTask(
BrowserThread::IO, FROM_HERE,
base::BindOnce(&URLLoaderFactoryGetter::InitializeOnIOThread, this,
- network_factory.PassInterface(),
- scoped_refptr<ChromeAppCacheService>(
- partition->GetAppCacheService())));
+ network_factory.PassInterface()));
}
mojom::URLLoaderFactoryPtr* URLLoaderFactoryGetter::GetNetworkFactory() {
@@ -42,20 +39,11 @@ void URLLoaderFactoryGetter::SetNetworkFactoryForTesting(
this, test_factory.PassInterface()));
}
-mojom::URLLoaderFactoryPtr* URLLoaderFactoryGetter::GetAppCacheFactory() {
- DCHECK_CURRENTLY_ON(BrowserThread::IO);
- return &appcache_factory_;
-}
-
URLLoaderFactoryGetter::~URLLoaderFactoryGetter() {}
void URLLoaderFactoryGetter::InitializeOnIOThread(
- mojom::URLLoaderFactoryPtrInfo network_factory,
- scoped_refptr<ChromeAppCacheService> appcache_service) {
+ mojom::URLLoaderFactoryPtrInfo network_factory) {
network_factory_.Bind(std::move(network_factory));
-
- AppCacheURLLoaderFactory::CreateURLLoaderFactory(
- mojo::MakeRequest(&appcache_factory_), appcache_service.get(), this);
}
void URLLoaderFactoryGetter::SetTestNetworkFactoryOnIOThread(

Powered by Google App Engine
This is Rietveld 408576698