Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1020)

Unified Diff: content/browser/appcache/appcache_job.h

Issue 2902653002: Get main frame and subframe AppCache loads to work. (Closed)
Patch Set: Add comments and helper functions Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/appcache/appcache_job.h
diff --git a/content/browser/appcache/appcache_job.h b/content/browser/appcache/appcache_job.h
index bc7a14b83b01c72b0427612472ec0d8208a74021..7b93126bcb6ea55d380f27638561c44a717fc598 100644
--- a/content/browser/appcache/appcache_job.h
+++ b/content/browser/appcache/appcache_job.h
@@ -37,6 +37,13 @@ class CONTENT_EXPORT AppCacheJob
: NON_EXPORTED_BASE(public base::NonThreadSafe),
public base::SupportsWeakPtr<AppCacheJob> {
public:
+ enum DeliveryType {
+ AWAITING_DELIVERY_ORDERS,
+ APPCACHED_DELIVERY,
+ NETWORK_DELIVERY,
+ ERROR_DELIVERY
+ };
+
// Callback that will be invoked before the request is restarted. The caller
// can use this opportunity to grab state from the job to determine how it
// should behave when the request is restarted.
@@ -65,19 +72,19 @@ class CONTENT_EXPORT AppCacheJob
virtual bool IsStarted() const = 0;
// Returns true if the job is waiting for instructions.
- virtual bool IsWaiting() const = 0;
+ virtual bool IsWaiting() const;
// Returns true if the job is delivering a response from the cache.
- virtual bool IsDeliveringAppCacheResponse() const = 0;
+ virtual bool IsDeliveringAppCacheResponse() const;
// Returns true if the job is delivering a response from the network.
- virtual bool IsDeliveringNetworkResponse() const = 0;
+ virtual bool IsDeliveringNetworkResponse() const;
// Returns true if the job is delivering an error response.
- virtual bool IsDeliveringErrorResponse() const = 0;
+ virtual bool IsDeliveringErrorResponse() const;
// Returns true if the cache entry was not found in the cache.
- virtual bool IsCacheEntryNotFound() const = 0;
+ virtual bool IsCacheEntryNotFound() const;
// Informs the job of what response it should deliver. Only one of these
// methods should be called, and only once per job. A job will sit idle and
@@ -111,6 +118,12 @@ class CONTENT_EXPORT AppCacheJob
protected:
AppCacheJob();
+ // Set to true if the AppCache entry is not found.
+ bool cache_entry_not_found_;
+
+ // The jobs delivery status.
+ DeliveryType delivery_type_;
+
base::WeakPtrFactory<AppCacheJob> weak_factory_;
DISALLOW_COPY_AND_ASSIGN(AppCacheJob);
« no previous file with comments | « no previous file | content/browser/appcache/appcache_job.cc » ('j') | content/browser/appcache/appcache_url_loader_factory.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698