Issue 2902633002: dart2js: replace 'invariant' with 'failedAt' to defer interpolation

Issue 2902633002: dart2js: replace 'invariant' with 'failedAt' to defer interpolation (Closed)

Created:
3 years, 7 months ago by sra1

Modified:
3 years, 7 months ago

Reviewers:
Johnni Winther, Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

dart2js: replace 'invariant' with 'failedAt' to defer interpolation Speeds up dart2js_builds by ~5% (probably more with more replacements). BUG= R=johnniwinther@google.com Committed: https://github.com/dart-lang/sdk/commit/641767c1da670788b04f1019ba627642b3f4e359

Created: 3 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+138 lines, -93 lines)			Patch
	M	pkg/compiler/lib/src/diagnostics/invariant.dart	View		2 chunks	+25 lines, -1 line	0 comments	Download
	M	pkg/compiler/lib/src/elements/modelx.dart	View		25 chunks	+113 lines, -92 lines	0 comments	Download

Total messages: 6 (2 generated)

sra1

WDYT? If we like this approach we would replace all calls to `invariant` like this.

3 years, 7 months ago (2017-05-22 22:30:41 UTC) #2

sra1

Committed patchset #1 (id:1) manually as 641767c1da670788b04f1019ba627642b3f4e359 (presubmit successful).

3 years, 7 months ago (2017-05-23 15:26:04 UTC) #5

Message was sent while issue was closed.

lgtm, thanks!