[Payment] should show all accepted card icon in payment editor.

chrome/android/java/src/org/chromium/chrome/browser/widget/ExpandableGridView.java

+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+package org.chromium.chrome.browser.widget;

[gone, 2017/06/01 00:08:28]

Confine this to payments/ui.  The stackoverflow post describes many ways this is
suboptimal and I'd hate for it to be used in situations where larger images are
used and memory is critical.

[Hwanseung Lee, 2017/06/01 14:36:38]

i moved it to payments/ui

+
+import android.content.Context;
+import android.util.AttributeSet;
+import android.view.View;
+import android.widget.GridView;
+
+/**
+ * This class is a customized GridView which draws items in multiple lines automatically

[gone, 2017/06/01 00:08:27]

End this comment with a period.

[Hwanseung Lee, 2017/06/01 14:36:38]

Done.

+ */
+public class ExpandableGridView extends GridView {
+    /** Constructor for when the gridview is inflated from XML. */
+    public ExpandableGridView(Context context, AttributeSet attrs) {
+        super(context, attrs);
+    }
+
+    @Override
+    public void onMeasure(int widthMeasureSpec, int heightMeasureSpec) {
+        int heightSpec;
+        if (getLayoutParams().height == LayoutParams.WRAP_CONTENT) {
+            heightSpec = MeasureSpec.makeMeasureSpec(View.MEASURED_SIZE_MASK, MeasureSpec.AT_MOST);

[gone, 2017/05/31 17:29:42]

This is a mask; you're supposed to use it to mask against the actual
measurespec, not use it as an actual width for makeMeasureSpec.  You're saying
that the height of this thing should be at most 16777215 pixels high.

Why do you think this is actually necessary?

[Hwanseung Lee, 2017/06/01 14:36:38]

i think it is not necessary.
i checked how to makeMeasureSpec work.
(https://cs.chromium.org/chromium/src/third_party/android_tools/sdk/sources/an...)

actually MeasureSpec.AT_MOST is enough big number.
so size(first parameter of makeMeasureSpec) is not important when use
MeasureSpec.AT_MOST as mode.
but i think it is symbolical mean which set big number to use
View.MEASURED_SIZE_MASK.

i changed it to parent's height. is it fine?
or to use 'Integer.MAX_VALUE & View.MEASURED_SIZE_MASK' is more better?

[gone, 2017/06/01 17:32:19]

Parent's height makes more sense, but I don't understand why AT_MOST is a "big
enough number".  AT_MOST is a flag that indicates that the height of this View
should only be AT MOST the first number you pass in.

+        } else {
+            heightSpec = heightMeasureSpec;
+        }
+
+        super.onMeasure(widthMeasureSpec, heightSpec);
+    }
+}