third_party/WebKit/Source/build/scripts/templates/fields/field.tmpl - Issue 2902433002: Generates predicates to test in diff functions in ComputedStyle

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/build/scripts/templates/fields/field.tmpl

Issue 2902433002: Generates predicates to test in diff functions in ComputedStyle (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/build/scripts/make_computed_style_base.py ('K') | « third_party/WebKit/Source/build/scripts/make_computed_style_base.py ('k') | third_party/WebKit/Source/core/css/ComputedStyleDiffFunctions.json5 » ('j') | third_party/WebKit/Source/core/css/ComputedStyleDiffFunctions.json5 » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/build/scripts/templates/fields/field.tmpl

diff --git a/third_party/WebKit/Source/build/scripts/templates/fields/field.tmpl b/third_party/WebKit/Source/build/scripts/templates/fields/field.tmpl

index 4ea422e216ee43446995951f3061123c37af8fdb..53c183e5b6199bbce1b0822857b74968eb1ea925 100644

--- a/third_party/WebKit/Source/build/scripts/templates/fields/field.tmpl

+++ b/third_party/WebKit/Source/build/scripts/templates/fields/field.tmpl

@@ -131,4 +131,8 @@ if ({{group.group_name}}.Get() != other.{{group.group_name}}.Get()) {

if (self.{{expression}} != other.{{expression}})

return true;

{% endfor %}

+{% for predicate in group_to_diff.predicates %}

+if (!self.{{predicate}})

+ return true;

+{% endfor %}

{% endmacro %}