Revert of Make non-Module generators only context allocate parameters.

Revert of Make non-Module generators only context allocate parameters. (patchset #11 id:220001 of https://codereview.chromium.org/2898163002/ )

Reason for revert:
Speculative revert for layout test changes:
https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/15868

Looks like this might have caused the change in:
inspector/sources/debugger-ui/function-generator-details.html

See also:
https://github.com/v8/v8/wiki/Blink-layout-tests

Original issue's description:
> Make non-Module generators only context allocate parameters.
> 
> In particular, local variables should be allocated on stack (in bytecode register), and stored/loaded to the generator object on generator suspend/resume.
> 
> The CL is based on @adamk's change to scoping/parsers (https://chromium-review.googlesource.com/c/498538/), I only made the debugger cope with this change.
> 
> I should note that the CL changes the scope type of suspended generators from ScopeType.Closure to ScopeType.Local. In the future we might want to introduce ScopeType.SuspendedGenerator to make the distinction explicit.
> 
> Some of the changes in the tests have been made because the debugger functions do not return scopes of closed generators anymore. Generators should be allowed to throw away their internal state when they finish.
> 
> BUG=v8:6368
> 
> Review-Url: https://codereview.chromium.org/2898163002
> Cr-Commit-Position: refs/heads/master@{#45515}
> Committed: https://chromium.googlesource.com/v8/v8/+/a957b0f42468d632b09574e3d6719c704eebbfea

TBR=adamk@chromium.org,jgruber@chromium.org,neis@chromium.org,jarin@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=v8:6368

[Michael Achenbach, 2017-05-25 17:38:41]

Created Revert of Make non-Module generators only context allocate parameters.

[Michael Achenbach, 2017-05-25 17:39:45]

FYI Alexey and Benedikt. Maybe we had two changes in a row that change layout
tests.

[Michael Achenbach, 2017-05-25 17:39:52]

The CQ bit was checked by machenbach@chromium.org

[commit-bot: I haz the power, 2017-05-25 17:39:57]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-25 17:41:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-25 17:41:27]

Try jobs failed on following builders:
  v8_linux64_gcc_compile_dbg on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gcc_compile_dbg/...)
  v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/26524)
  v8_linux_gcc_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...)
  v8_linux_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/26431)
  v8_linux_verify_csa_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_verify_csa_rel_ng/...)

[kozy, 2017-05-25 22:46:01]

kozyatinskiy@chromium.org changed reviewers:
+ kozyatinskiy@chromium.org

[kozy, 2017-05-25 22:46:02]

I'll revert it tomorrow manually. Based on test results - before we was able to
show suspended scopes not on pause in console, now - we don't show these scopes.

[kozy, 2017-05-26 09:41:35]

Description was changed from

==========
Revert of Make non-Module generators only context allocate parameters. (patchset
#11 id:220001 of https://codereview.chromium.org/2898163002/ )

Reason for revert:
Speculative revert for layout test changes:
https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/bui...

Looks like this might have caused the change in:
inspector/sources/debugger-ui/function-generator-details.html

See also:
https://github.com/v8/v8/wiki/Blink-layout-tests

Original issue's description:
> Make non-Module generators only context allocate parameters.
> 
> In particular, local variables should be allocated on stack (in bytecode
register), and stored/loaded to the generator object on generator
suspend/resume.
> 
> The CL is based on @adamk's change to scoping/parsers
(https://chromium-review.googlesource.com/c/498538/), I only made the debugger
cope with this change.
> 
> I should note that the CL changes the scope type of suspended generators from
ScopeType.Closure to ScopeType.Local. In the future we might want to introduce
ScopeType.SuspendedGenerator to make the distinction explicit.
> 
> Some of the changes in the tests have been made because the debugger functions
do not return scopes of closed generators anymore. Generators should be allowed
to throw away their internal state when they finish.
> 
> BUG=v8:6368
> 
> Review-Url: https://codereview.chromium.org/2898163002
> Cr-Commit-Position: refs/heads/master@{#45515}
> Committed:
https://chromium.googlesource.com/v8/v8/+/a957b0f42468d632b09574e3d6719c704ee...

TBR=adamk@chromium.org,jgruber@chromium.org,neis@chromium.org,jarin@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=v8:6368
==========

to

==========
Revert of Make non-Module generators only context allocate parameters. (patchset
#11 id:220001 of https://codereview.chromium.org/2898163002/ )

Reason for revert:
Speculative revert for layout test changes:
https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/bui...

Looks like this might have caused the change in:
inspector/sources/debugger-ui/function-generator-details.html

See also:
https://github.com/v8/v8/wiki/Blink-layout-tests

Original issue's description:
> Make non-Module generators only context allocate parameters.
> 
> In particular, local variables should be allocated on stack (in bytecode
register), and stored/loaded to the generator object on generator
suspend/resume.
> 
> The CL is based on @adamk's change to scoping/parsers
(https://chromium-review.googlesource.com/c/498538/), I only made the debugger
cope with this change.
> 
> I should note that the CL changes the scope type of suspended generators from
ScopeType.Closure to ScopeType.Local. In the future we might want to introduce
ScopeType.SuspendedGenerator to make the distinction explicit.
> 
> Some of the changes in the tests have been made because the debugger functions
do not return scopes of closed generators anymore. Generators should be allowed
to throw away their internal state when they finish.
> 
> BUG=v8:6368
> 
> Review-Url: https://codereview.chromium.org/2898163002
> Cr-Commit-Position: refs/heads/master@{#45515}
> Committed:
https://chromium.googlesource.com/v8/v8/+/a957b0f42468d632b09574e3d6719c704ee...

TBR=adamk@chromium.org,jgruber@chromium.org,neis@chromium.org,jarin@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=v8:6368
==========

[kozy, 2017-05-26 09:41:58]

Removing scopes for closed generators is one of the intention of original CL, so
we need to mark related tests as NeedsManualRebaseline only and rebase it later:
https://codereview.chromium.org/2910623002