Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Unified Diff: base/trace_event/trace_config.cc

Issue 2902413002: memory-infra: remove light dumps and increment default dump time to 5s (Closed)
Patch Set: Undo crrev.com/2815963002, fire first timer immediately Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/trace_event/memory_dump_scheduler.cc ('k') | base/trace_event/trace_config_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/trace_event/trace_config.cc
diff --git a/base/trace_event/trace_config.cc b/base/trace_event/trace_config.cc
index 7ee9a4a101b4f13dcd4455be4a5406aa1b9e5e45..b6fefa96aafd33dab84d41d09e876bd8afba485a 100644
--- a/base/trace_event/trace_config.cc
+++ b/base/trace_event/trace_config.cc
@@ -52,12 +52,9 @@ const char kFilterPredicateParam[] = "filter_predicate";
const char kFilterArgsParam[] = "filter_args";
// Default configuration of memory dumps.
-const TraceConfig::MemoryDumpConfig::Trigger kDefaultHeavyMemoryDumpTrigger = {
- 2000, // min_time_between_dumps_ms
+const TraceConfig::MemoryDumpConfig::Trigger kDefaultMemoryDumpTrigger = {
+ 5000, // min_time_between_dumps_ms
MemoryDumpLevelOfDetail::DETAILED, MemoryDumpType::PERIODIC_INTERVAL};
-const TraceConfig::MemoryDumpConfig::Trigger kDefaultLightMemoryDumpTrigger = {
- 250, // min_time_between_dumps_ms
- MemoryDumpLevelOfDetail::LIGHT, MemoryDumpType::PERIODIC_INTERVAL};
class ConvertableTraceConfigToTraceFormat
: public base::trace_event::ConvertableToTraceFormat {
@@ -462,8 +459,7 @@ void TraceConfig::SetMemoryDumpConfigFromConfigDict(
void TraceConfig::SetDefaultMemoryDumpConfig() {
memory_dump_config_.Clear();
- memory_dump_config_.triggers.push_back(kDefaultHeavyMemoryDumpTrigger);
- memory_dump_config_.triggers.push_back(kDefaultLightMemoryDumpTrigger);
+ memory_dump_config_.triggers.push_back(kDefaultMemoryDumpTrigger);
memory_dump_config_.allowed_dump_modes = GetDefaultAllowedMemoryDumpModes();
}
« no previous file with comments | « base/trace_event/memory_dump_scheduler.cc ('k') | base/trace_event/trace_config_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698