Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Unified Diff: ios/web_view/test/chrome_web_view_test.h

Issue 2902403002: Add KVO compliant title property to CWVWebView. (Closed)
Patch Set: Remove observers directory. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/web_view/test/chrome_web_view_kvo_inttest.mm ('k') | ios/web_view/test/chrome_web_view_test.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/web_view/test/chrome_web_view_test.h
diff --git a/ios/web_view/test/chrome_web_view_test.h b/ios/web_view/test/chrome_web_view_test.h
index 5605a64976d6fb15cf8f0f8ef1a0975d9c3cc571..389338a469e416657322995ee7a3de019d56651e 100644
--- a/ios/web_view/test/chrome_web_view_test.h
+++ b/ios/web_view/test/chrome_web_view_test.h
@@ -23,9 +23,8 @@ class GURL;
namespace ios_web_view {
// A test fixture for testing CWVWebView. A test server is also created to
-// support loading content. The server supports the urls defined by
-// RegisterDefaultHandlers in net/test/embedded_test_server/default_handlers.h
-// as well as urls returned by the GetUrl* methods below.
+// support loading content. The server supports the urls returned by the GetUrl*
+// methods below.
class ChromeWebViewTest : public PlatformTest {
protected:
ChromeWebViewTest();
@@ -35,7 +34,12 @@ class ChromeWebViewTest : public PlatformTest {
GURL GetUrlForPageWithTitle(const std::string& title);
// Returns URL to an html page with |html| within page's body tags.
- GURL GetUrlForPageWithHTMLBody(const std::string& html);
+ GURL GetUrlForPageWithHtmlBody(const std::string& html);
+
+ // Returns URL to an html page with title set to |title| and |body| within
+ // the page's body tags.
+ GURL GetUrlForPageWithTitleAndBody(const std::string& title,
+ const std::string& body);
// Loads |URL| in |web_view| and waits until the load completes. Asserts if
// loading does not complete.
@@ -47,9 +51,8 @@ class ChromeWebViewTest : public PlatformTest {
// PlatformTest methods.
void SetUp() override;
- // Embedded server for handling responses to urls as registered by
- // net/test/embedded_test_server/default_handlers.h and the GetURLForPageWith*
- // methods.
+ // Embedded server for handling requests sent to the URLs returned by the
+ // GetURL* methods.
std::unique_ptr<net::test_server::EmbeddedTestServer> test_server_;
};
« no previous file with comments | « ios/web_view/test/chrome_web_view_kvo_inttest.mm ('k') | ios/web_view/test/chrome_web_view_test.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698