 Chromium Code Reviews
 Chromium Code Reviews Issue 2902393002:
   [vr] Bail on unhandled code points.  (Closed)
    
  
    Issue 2902393002:
   [vr] Bail on unhandled code points.  (Closed) 
  | Index: chrome/browser/android/vr_shell/font_fallback.h | 
| diff --git a/chrome/browser/android/vr_shell/font_fallback.h b/chrome/browser/android/vr_shell/font_fallback.h | 
| index 5eb85c6dd3eb3c7c1882a8f7e18dccdc24f8559f..c0104aa19c386c3814a3196d209cd66d97fd153b 100644 | 
| --- a/chrome/browser/android/vr_shell/font_fallback.h | 
| +++ b/chrome/browser/android/vr_shell/font_fallback.h | 
| @@ -22,11 +22,19 @@ namespace vr_shell { | 
| // preferred_locale: preferred locale identifier (if any) for |c| | 
| // (e.g. "en", "ja", "zh-CN") | 
| // | 
| -// Returns: the font name. The value is empty if the request could not be | 
| -// satisfied or if the provided default font supports it. | 
| -std::string GetFallbackFontNameForChar(const gfx::Font& default_font, | 
| - UChar32 c, | 
| - const std::string& preferred_locale); | 
| +// The funtion, if it succeeds, sets |font_name|. Even if it succeeds, it may | 
| 
amp
2017/05/26 20:37:39
s/funtion/function
 | 
| +// set |font_name| to the empty string if the character is supported by the | 
| +// default font. | 
| +// | 
| +// Returns: | 
| +// * false, if the request could not be satisfied or if the provided default | 
| +// font supports it. | 
| +// * true, otherwis. | 
| +// | 
| +bool GetFallbackFontNameForChar(const gfx::Font& default_font, | 
| + UChar32 c, | 
| + const std::string& preferred_locale, | 
| + std::string* font_name); | 
| } // namespace vr_shell |