chrome/browser/android/vr_shell/textures/insecure_content_transient_texture.cc - Issue 2902393002: [vr] Bail on unhandled code points.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/vr_shell/textures/insecure_content_transient_texture.cc

Issue 2902393002: [vr] Bail on unhandled code points. (Closed)

Patch Set: . Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/android/vr_shell/textures/insecure_content_permanent_texture.cc ('k') | chrome/browser/android/vr_shell/textures/system_indicator_texture.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/vr_shell/textures/insecure_content_transient_texture.cc

diff --git a/chrome/browser/android/vr_shell/textures/insecure_content_transient_texture.cc b/chrome/browser/android/vr_shell/textures/insecure_content_transient_texture.cc

index 0fd603da6e2753380eec04eba6d9257766fbe733..536bb8dc74979936376e7f506ce5e0d7fc440caa 100644

--- a/chrome/browser/android/vr_shell/textures/insecure_content_transient_texture.cc

+++ b/chrome/browser/android/vr_shell/textures/insecure_content_transient_texture.cc

@@ -43,7 +43,8 @@ void InsecureContentTransientTexture::Draw(SkCanvas* sk_canvas,

paint.setColor(kBackgroundColor);

auto text =

l10n_util::GetStringUTF16(IDS_PAGE_INFO_INSECURE_WEBVR_CONTENT_TRANSIENT);

- auto fonts = GetFontList(size_.width() * kFontSizeFactor, text);

+ gfx::FontList fonts;

+ GetFontList(size_.width() * kFontSizeFactor, text, &fonts);

gfx::Rect text_size(size_.width() * kTextWidthFactor, 0);

std::vector<std::unique_ptr<gfx::RenderText>> lines =