[vr] Bail on unhandled code points.

chrome/browser/android/vr_shell/textures/url_bar_texture_unittest.cc

+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/android/vr_shell/textures/url_bar_texture.h"
+
+#include "base/bind.h"
+#include "base/macros.h"
+#include "testing/gtest/include/gtest/gtest.h"
+#include "third_party/skia/include/core/SkSurface.h"
+#include "ui/gfx/font_list.h"
+
+namespace vr_shell {
+
+namespace {
+
+static constexpr int kUrlWidth = 400;
+static constexpr int kUrlHeight = 30;
+
+class TestUrlBarTexture : public UrlBarTexture {
+ public:
+  TestUrlBarTexture();
+  ~TestUrlBarTexture() override {}
+
+  void DrawURL(const GURL& gurl) {
+    unsupported_mode_ = UiUnsupportedMode::kMax;
+    SetURL(gurl);
+    sk_sp<SkSurface> surface = SkSurface::MakeRasterN32Premul(
+        texture_size_.width(), texture_size_.height());
+    DrawAndLayout(surface->getCanvas(), texture_size_);
+  }
+
+  void SetForceFontFallbackFailure(bool force) {

[cjgrant, 2017/05/26 18:52:00]

I'm not suggesting a change in this CL, but am curious.  Another common way to
do this testing is to have an alternate test constructor that takes in helper
classes, allowing use of a mock/fake text classes.  We should talk about this
offline, as soon we'll be writing *many* tests, right?  :)

[Ian Vollick, 2017/05/26 20:20:28]

In this case, I wonder if we can make the static functions on UiTexture member
functions for easier testing? Let's chat about how best to approach this
offline.

+    SetForceFontFallbackFailureForTesting(force);
+  }
+
+  // Reports the last unsupported mode that was encountered. Returns kMax if no
+  // unsupported mode was encountered.
+  UiUnsupportedMode unsupported_mode() const { return unsupported_mode_; }
+
+ private:
+  void OnUnsupportedFeature(UiUnsupportedMode mode) {
+    unsupported_mode_ = mode;
+  }
+
+  gfx::Size texture_size_;
+  gfx::Rect bounds_;
+  UiUnsupportedMode unsupported_mode_ = UiUnsupportedMode::kMax;
+};
+
+TestUrlBarTexture::TestUrlBarTexture()
+    : UrlBarTexture(base::Bind(&TestUrlBarTexture::OnUnsupportedFeature,
+                               base::Unretained(this))),
+      texture_size_(kUrlWidth, kUrlHeight),
+      bounds_(kUrlWidth, kUrlHeight) {
+  gfx::FontList::SetDefaultFontDescription("Arial, Times New Roman, 15px");
+}
+
+}  // namespace
+
+TEST(UrlBarTexture, WillFailOnUnhandledCodePoint) {
+  TestUrlBarTexture texture;
+  texture.DrawURL(GURL("https://foo.com"));
+  EXPECT_EQ(UiUnsupportedMode::kMax, texture.unsupported_mode());
+  texture.SetForceFontFallbackFailure(true);
+  texture.DrawURL(GURL("https://bar.com"));
+  EXPECT_EQ(UiUnsupportedMode::kUnhandledCodePoint, texture.unsupported_mode());
+  texture.SetForceFontFallbackFailure(false);
+  texture.DrawURL(GURL("https://baz.com"));
+  EXPECT_EQ(UiUnsupportedMode::kMax, texture.unsupported_mode());
+}
+
+}  // namespace vr_shell