Fix memory leak in unit test

chrome/browser/component_updater/cros_component_installer_unittest.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/component_updater/cros_component_installer.h"
 
 #include "base/memory/ptr_util.h"
 #include "base/run_loop.h"
 #include "base/test/test_simple_task_runner.h"
 #include "base/threading/thread_task_runner_handle.h"
@@ skipping 15 matching lines @@
     return base::ThreadTaskRunnerHandle::Get();
   }
 
  private:
   DISALLOW_COPY_AND_ASSIGN(CrOSMockComponentUpdateService);
 };
 
 class CrOSComponentInstallerTest : public PlatformTest {
  public:
   CrOSComponentInstallerTest() {}
-  void SetUp() override { PlatformTest::SetUp(); }
+  void SetUp() override {
+    PlatformTest::SetUp();
+    bppp_ = std::make_shared<BrowserProcessPlatformPart>();
+  }
+  std::shared_ptr<BrowserProcessPlatformPart> GetBPPP() { return bppp_; }
 
  private:
   content::TestBrowserThreadBundle thread_bundle_;
+  std::shared_ptr<BrowserProcessPlatformPart> bppp_;
+
   DISALLOW_COPY_AND_ASSIGN(CrOSComponentInstallerTest);
 };
 
 class FakeInstallerTraits : public ComponentInstallerTraits {
  public:
   ~FakeInstallerTraits() override {}
 
   bool VerifyInstallation(const base::DictionaryValue& manifest,
                           const base::FilePath& dir) const override {
     return true;
@@ skipping 30 matching lines @@
   }
 
   std::vector<std::string> GetMimeTypes() const override {
     return std::vector<std::string>();
   }
 };
 
 void install_callback(update_client::Error error) {}
 
 TEST_F(CrOSComponentInstallerTest, BPPPCompatibleCrOSComponent) {
-  auto* bppp = new BrowserProcessPlatformPart();
-  ASSERT_EQ(bppp->IsCompatibleCrOSComponent("a"), false);
-  bppp->AddCompatibleCrOSComponent("a");
-  ASSERT_EQ(bppp->IsCompatibleCrOSComponent("a"), true);
+  ASSERT_EQ(GetBPPP()->IsCompatibleCrOSComponent("a"), false);

[sky, 2017/05/26 03:11:12]

I'm suggesting you do this:

  BrowserProcessPlatformPart bppp;
  bppp.AddComp...

Why do you need the make_shared above?

[xiaochu, 2017/05/26 03:21:21]

Done.

+  GetBPPP()->AddCompatibleCrOSComponent("a");
+  ASSERT_EQ(GetBPPP()->IsCompatibleCrOSComponent("a"), true);
 }
 
 TEST_F(CrOSComponentInstallerTest, RegisterComponentFail) {
   std::unique_ptr<CrOSMockComponentUpdateService> cus =
       base::MakeUnique<CrOSMockComponentUpdateService>();
   EXPECT_CALL(*cus, RegisterComponent(testing::_)).Times(0);
   component_updater::CrOSComponent::InstallCrOSComponent(
       "a-component-not-exist", base::Bind(install_callback));
   base::RunLoop().RunUntilIdle();
 }
 
 }  // namespace component_updater