Introduce lock screen app manager

chrome/browser/chromeos/note_taking_helper.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/note_taking_helper.h"
 
 #include <algorithm>
 #include <utility>
 
 #include "apps/launcher.h"
@@ skipping 135 matching lines @@
               prefs::kNoteTakingAppEnabledOnLockScreen)) {
         info.lock_screen_support = NoteTakingLockScreenSupport::kSelected;
       }
       break;
     }
   }
 
   return infos;
 }
 
+std::unique_ptr<NoteTakingAppInfo> NoteTakingHelper::GetPreferredChromeAppInfo(
+    Profile* profile) {
+  if (!ash::palette_utils::HasStylusInput())

[jdufault, 2017/05/26 19:15:53]

Why do we disable preferred app if there is no stylus?

[tbarzic, 2017/05/26 19:34:14]

Yeah, I guess we don;t have to.

+    return nullptr;
+  std::string preferred_app_id =
+      profile->GetPrefs()->GetString(prefs::kNoteTakingAppId);
+  if (LooksLikeAndroidPackageName(preferred_app_id))

[jdufault, 2017/05/26 19:15:53]

Add a comment,

// Lock screen does not currently support android.

[tbarzic, 2017/05/26 19:34:14]

Added a comment, but at the place where this method is used.
(returning null here matches the method name nicely, and I don't think it needs
extra clarification)

+    return nullptr;
+  const extensions::Extension* preferred_app =
+      extensions::ExtensionRegistry::Get(profile)->GetExtensionById(
+          preferred_app_id, extensions::ExtensionRegistry::ENABLED);
+  if (!preferred_app)
+    return nullptr;
+  if (!IsWhitelistedChromeApp(preferred_app) &&
+      !extensions::ActionHandlersInfo::HasActionHandler(
+          preferred_app, app_runtime::ACTION_TYPE_NEW_NOTE)) {
+    return nullptr;
+  }
+  NoteTakingLockScreenSupport lock_screen_support =
+      NoteTakingLockScreenSupport::kNotSupported;
+  if (IsLockScreenEnabled(preferred_app)) {
+    if (profile->GetPrefs()->GetBoolean(
+            prefs::kNoteTakingAppEnabledOnLockScreen)) {
+      lock_screen_support = NoteTakingLockScreenSupport::kSelected;
+    } else {
+      lock_screen_support = NoteTakingLockScreenSupport::kSupported;
+    }
+  }
+  std::unique_ptr<NoteTakingAppInfo> info =
+      base::MakeUnique<NoteTakingAppInfo>();
+  info->name = preferred_app->name();
+  info->app_id = preferred_app->id();
+  info->preferred = true;
+  info->lock_screen_support = lock_screen_support;
+  return info;
+}
+
 void NoteTakingHelper::SetPreferredApp(Profile* profile,
                                        const std::string& app_id) {
   DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
   DCHECK(profile);
 
   const extensions::Extension* app =
       extensions::ExtensionRegistry::Get(profile)->GetExtensionById(
           app_id, extensions::ExtensionRegistry::ENABLED);
 
   if (!app || !IsLockScreenEnabled(app)) {
@@ skipping 296 matching lines @@
     for (auto& observer : observers_)
       observer.OnAvailableNoteTakingAppsUpdated();
   }
 }
 
 void NoteTakingHelper::OnShutdown(extensions::ExtensionRegistry* registry) {
   extension_registry_observer_.Remove(registry);
 }
 
 }  // namespace chromeos