Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Issue 2902193002: Add navigation support in plugins (Closed)

Created:
3 years, 7 months ago by Brian Wilkerson
Modified:
3 years, 7 months ago
Reviewers:
maxkim, scheglov, mfairhurst
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+412 lines, -0 lines) Patch
A pkg/analyzer_plugin/lib/src/utilities/navigation.dart View 1 chunk +83 lines, -0 lines 0 comments Download
A pkg/analyzer_plugin/lib/utilities/navigation.dart View 1 chunk +85 lines, -0 lines 0 comments Download
A pkg/analyzer_plugin/lib/utilities/pair.dart View 1 chunk +27 lines, -0 lines 0 comments Download
A pkg/analyzer_plugin/test/src/utilities/navigation_test.dart View 1 chunk +127 lines, -0 lines 0 comments Download
M pkg/analyzer_plugin/test/src/utilities/test_all.dart View 1 chunk +2 lines, -0 lines 0 comments Download
A pkg/analyzer_plugin/test/utilities/navigation_test.dart View 1 chunk +86 lines, -0 lines 0 comments Download
M pkg/analyzer_plugin/test/utilities/test_all.dart View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
A first cut at an API to simplify plugin implementation. This is targeted at navigation, ...
3 years, 7 months ago (2017-05-24 16:46:43 UTC) #2
scheglov
LGTM
3 years, 7 months ago (2017-05-24 17:21:41 UTC) #3
Brian Wilkerson
3 years, 7 months ago (2017-05-24 22:06:23 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6bff3433b7098f8b8baf7b608cd7b289167be78e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698