Improve determination of managed state in DeviceSettingsProvider

chrome/browser/chromeos/settings/device_settings_provider.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/settings/device_settings_provider.h"
 
 #include <memory.h>
 #include <stddef.h>
 #include <utility>
 
@@ skipping 724 matching lines @@
 
   UpdateValuesCache(policy_data, device_settings_, trusted_status_);
 }
 
 void DeviceSettingsProvider::UpdateValuesCache(
     const em::PolicyData& policy_data,
     const em::ChromeDeviceSettingsProto& settings,
     TrustedStatus trusted_status) {
   PrefValueMap new_values_cache;
 
+  // Determine whether device is unmanaged. See PolicyData::management_mode
+  // docs for details.
+  bool unmanaged = false;

[Roman Sorokin (ftl), 2017/05/29 16:19:53]

why not "managed = true" ?

Negative name is confusing :)

[Thiemo Nagel, 2017/05/30 12:25:07]

Done.

+  if (policy_data.has_management_mode()) {
+    if (policy_data.management_mode() != em::PolicyData::ENTERPRISE_MANAGED)
+      unmanaged = true;
+  } else if (!policy_data.has_request_token()) {
+    unmanaged = true;
+  }
+
   // If the device is not managed, we set the device owner value.
-  if (policy_data.has_username() && !policy_data.has_request_token())
+  if (policy_data.has_username() && unmanaged)
     new_values_cache.SetString(kDeviceOwner, policy_data.username());
 
   if (policy_data.has_service_account_identity()) {
     new_values_cache.SetString(kServiceAccountIdentity,
                                policy_data.service_account_identity());
   }
 
   DecodeLoginPolicies(settings, &new_values_cache);
   DecodeNetworkPolicies(settings, &new_values_cache);
   DecodeAutoUpdatePolicies(settings, &new_values_cache);
@@ skipping 143 matching lines @@
   // Notify the observers we are done.
   std::vector<base::Closure> callbacks;
   callbacks.swap(callbacks_);
   for (size_t i = 0; i < callbacks.size(); ++i)
     callbacks[i].Run();
 
   return settings_loaded;
 }
 
 }  // namespace chromeos