Issue 2902153003: fasta: revert check for null fileUri in the error reporting of the verifier.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2902153003: fasta: revert check for null fileUri in the error reporting of the verifier. (Closed)

Created:
3 years, 7 months ago by Siggi Cherem (dart-lang)

Modified:
3 years, 7 months ago

Reviewers:
ahe

CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com

Target Ref:
refs/heads/master

Visibility:
Public.

fasta: revert check for null fileUri in the error reporting of the verifier. (as discussed in https://codereview.chromium.org/2894283002, we are reverting this because we don't know how to reproduce this issue anymore. When it comes up again we can either fix the issue or re-revert and include an explanation). R=ahe@google.com Committed: https://github.com/dart-lang/sdk/commit/5f8bc4feb2d96e99895b60ea120b43c62d0cd6a4

Created: 3 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -3 lines)			Patch
	M	pkg/front_end/lib/src/fasta/kernel/verifier.dart	View		1 chunk	+1 line, -3 lines	0 comments	Download

Total messages: 4 (1 generated)

Siggi Cherem (dart-lang)

3 years, 7 months ago (2017-05-24 18:17:22 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
5f8bc4feb2d96e99895b60ea120b43c62d0cd6a4 (presubmit successful).