View shows wrong bound when it is highlighted.

ash/devtools/ash_devtools_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/devtools/ash_devtools_css_agent.h"
 #include "ash/devtools/ash_devtools_dom_agent.h"
 #include "ash/devtools/ui_element.h"
+#include "ash/devtools/view_element.h"
+#include "ash/devtools/widget_element.h"
 #include "ash/devtools/window_element.h"
 #include "ash/public/cpp/shell_window_ids.h"
 #include "ash/root_window_controller.h"
 #include "ash/shell.h"
 #include "ash/test/ash_test_base.h"
 #include "ash/wm/widget_finder.h"
 #include "base/memory/ptr_util.h"
 #include "base/strings/stringprintf.h"
 #include "ui/display/display.h"
 #include "ui/views/background.h"
@@ skipping 610 matching lines @@
   DOM::Node* parent_node = FindInRoot(parent_window, root.get());
   ASSERT_TRUE(parent_node);
   Array<DOM::Node>* parent_children = parent_node->getChildren(nullptr);
   ASSERT_TRUE(parent_children);
   DOM::Node* window_node = parent_children->get(1);
   DOM::Node* widget_node = parent_children->get(0);
   DOM::Node* root_view_node = widget_node->getChildren(nullptr)->get(0);
 
   HighlightNode(window_node->getNodeId());
   ExpectHighlighted(window->GetBoundsInScreen(), 0);
+  devtools::WindowElement* window_element =
+      static_cast<devtools::WindowElement*>(

[sadrul, 2017/05/25 21:27:49]

You don't need to use a WindowElement* here. Just:
  devtools::UIElement* element =
dom_agent()->GetElementFromNodeId(window_node->getNodeId());
  ASSERT_EQ(devtools::UIElementType::WINDOW, element->type());
  EXPECT_EQ(element->GetNodeWindowAndBounds().first, window.get());
  EXPECT_EQ(element->GetNodeWindowAndBounds().second,
window->GetBoundsInScreen());

+          dom_agent()->GetElementFromNodeId(window_node->getNodeId()));
+  EXPECT_EQ(window_element->GetNodeWindowAndBounds().first, window.get());
+  EXPECT_EQ(window_element->GetNodeWindowAndBounds().second,
+            window->GetBoundsInScreen());
 
   HideHighlight(0);
 
   HighlightNode(widget_node->getNodeId());
   ExpectHighlighted(widget->GetWindowBoundsInScreen(), 0);
 
+  devtools::WidgetElement* widget_element =
+      static_cast<devtools::WidgetElement*>(
+          dom_agent()->GetElementFromNodeId(widget_node->getNodeId()));

[sadrul, 2017/05/25 21:27:49]

Don't need the static cast. Just use UIElement.

+  EXPECT_EQ(widget_element->GetNodeWindowAndBounds().first,
+            widget->GetNativeWindow());
+  EXPECT_EQ(widget_element->GetNodeWindowAndBounds().second,
+            widget->GetWindowBoundsInScreen());
+
   HideHighlight(0);
 
   HighlightNode(root_view_node->getNodeId());
   ExpectHighlighted(root_view->GetBoundsInScreen(), 0);
 
+  devtools::ViewElement* view_element = static_cast<devtools::ViewElement*>(

[sadrul, 2017/05/25 21:27:49]

ditto

+      dom_agent()->GetElementFromNodeId(root_view_node->getNodeId()));
+  EXPECT_EQ(view_element->GetNodeWindowAndBounds().first,
+            root_view->GetWidget()->GetNativeWindow());
+  EXPECT_EQ(view_element->GetNodeWindowAndBounds().second,
+            root_view->GetBoundsInScreen());
+
   HideHighlight(0);
 
   // Highlight non-existent node
   HighlightNode(10000);
   EXPECT_FALSE(GetHighlightingWindow(0)->IsVisible());
 }
 
 int GetNodeIdFromWindow(devtools::UIElement* ui_element, aura::Window* window) {
   for (auto* child : ui_element->children()) {
     if (child->type() == devtools::UIElementType::WINDOW &&
@@ skipping 156 matching lines @@
   SetStyleTexts(root_view_node, "\nheight: 73;\n  ", true);
   EXPECT_EQ(gfx::Rect(25, 35, 45, 73), root_view->bounds());
 
   SetStyleTexts(root_view_node, "\nx: 10; y: 23; width: 52;\nvisibility: 1;\n",
                 true);
   EXPECT_EQ(gfx::Rect(10, 23, 52, 73), root_view->bounds());
   EXPECT_TRUE(root_view->visible());
 }
 
 }  // namespace ash