Fix new space allocation in parser which can be triggered on background compiler

Fix new space allocation in parser which can be triggered on background compiler

This CL introduces also `Parser::allocation_space_` field which is set
to Heap::kNew on mutator thread and Heap::kOld on all other threads.

R=asiva@google.com, vegorov@google.com

Committed: https://github.com/dart-lang/sdk/commit/ef71b485eb6776754558090c9cef9d0d62c9b36f

[kustermann, 2017-05-24 15:51:28]

kustermann@google.com changed reviewers:
+ asiva@google.com, vegorov@google.com

[kustermann, 2017-05-24 15:51:29]

In order to catch all new-space allocations reachable from the parser
(transitively), I've made [experiment] which shows a lot of allocations would
need to change (either to go directly into old-space or do it based on
IsMutatorThread()), see [changes].

Now it is of course true, that some of the transitive code paths reachable from
the parser are not invoked on the background compiler, though I think it's quite
fragile to make this fine-grained, since any changes to the background compiler
might introduce new code paths which do new-space allocations.

As discussed in the meeting, we could change the assertion in 

  Object::Allocate() {
    ASSERT(thread->IsMutatorThread() || (space != Heap::kNew));
    ...
  }

to be a release assertion.

BUT: But since it's a dynamic property (and bg compilation is quite
non-deterministic) we might not find all issues, so customers might still run
into crashes (at this assertion).

Therefore, if we want to be more pessimistic, we can do something similar to
[experiment] which can ensure that transitive closure of parser does the right
thing (e.g. our vm-debug builders).

[experiment] https://codereview.chromium.org/2901103004/
[changes] https://codereview.chromium.org/2899323002

[siva, 2017-05-25 01:33:07]

lgtm

[kustermann, 2017-05-29 08:41:50]

Patchset #2 (id:20001) has been deleted

[Vyacheslav Egorov (Google), 2017-05-29 08:57:43]

lgtm

[kustermann, 2017-05-29 09:06:58]

Description was changed from

==========
Fix new space allocation in parser which can be triggered on background compiler

This CL introduces also `Parser::allocation_space_` field which is set
to Heap::kNew on mutator thread and Heap::kOld on all other threads.
==========

to

==========
Fix new space allocation in parser which can be triggered on background compiler

This CL introduces also `Parser::allocation_space_` field which is set
to Heap::kNew on mutator thread and Heap::kOld on all other threads.

R=asiva@google.com, vegorov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/ef71b485eb6776754558090c9cef9d0d62c9b36f
==========

[kustermann, 2017-05-29 09:06:59]

Committed patchset #1 (id:1) manually as
ef71b485eb6776754558090c9cef9d0d62c9b36f (presubmit successful).