Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(80)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: components/test/data/search_engines/simple_open_search_no_name.xml
Issue
2902043004
:
Omnibox - Open Search - Handle Lack of Short Name Smartly (Closed)
Patch Set: pkasting comments
Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
chrome/browser/search_engines/template_url_fetcher_unittest.cc
chrome/test/data/simple_open_search_no_name.xml
components/search_engines/template_url_data.cc
components/search_engines/template_url_parser.cc
components/test/data/search_engines/simple_open_search_no_name.xml
View unified diff
|
Download patch
« no previous file with comments
|
« components/search_engines/template_url_parser.cc
('k') |
no next file »
|
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
<?xml version="1.0"?>
2
<OpenSearchDescription xmlns="http://a9.com/-/spec/opensearch/1.1/">
3
<ShortName/>
4
<Description>Not a creative description.</Description>
5
<Url type="text/html" template="http://example.com/{searchTerms}/other_stuff"/>
6
</OpenSearchDescription>
OLD
NEW
« no previous file with comments
|
« components/search_engines/template_url_parser.cc
('k') |
no next file »
|
no next file with comments »
Issue 2902043004: Omnibox - Open Search - Handle Lack of Short Name Smartly (Closed)
Created 3 years, 7 months ago by Mark P
Modified 3 years, 6 months ago
Reviewers: Peter Kasting
Base URL:
Comments: 12
This is Rietveld
408576698