chrome/test/data/simple_open_search_no_name.xml - Issue 2902043004: Omnibox - Open Search - Handle Lack of Short Name Smartly

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/data/simple_open_search_no_name.xml

Issue 2902043004: Omnibox - Open Search - Handle Lack of Short Name Smartly (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <?xml version="1.0"?>
	Peter Kasting 2017/05/26 01:38:39 How come we need both this file and the one in com How come we need both this file and the one in components/? Is one of them not actually used? Mark P 2017/05/26 21:56:26 I believe we only need the components one, but the Show quoted text On 2017/05/26 01:38:39, Peter Kasting wrote: > How come we need both this file and the one in components/? Is one of them not > actually used? I believe we only need the components one, but the simple_open_search.xml exists on both places and I think it makes most sense to keep this parallel. This looks like it's being fixed as part of bug 527882, which is out of scope of this changelist.
	2 <OpenSearchDescription xmlns="http://a9.com/-/spec/opensearch/1.1/">

	3 <ShortName/>

	4 <Description>Not a creative description.</Description>

	5 <Url type="text/html" template="http://example.com/{searchTerms}/other_stuff"/>

	6 </OpenSearchDescription>

OLD	NEW