Refactor test option parsing code.

Refactor test option parsing code.

This doesn’t touch the resulting configuration map, which is what this
is leading up to, but it cleans up the specification and parsing of the
options and removes a lot of redundancy.

Behavior should be the same as it was before, except that all options
now allow both their underscore-separated and hyphen-separated names.
So this is now valid:

test.py --hot_reload --append-logs

Where before, you use to have to do --hot-reload (OK) and
--append_logs (bad, since almost all other options expect hyphens).

R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/9c2dff8ebc9f2c53d23ae46f71cf6e3b95a0e823

[Bob Nystrom, 2017-05-23 21:14:38]

rnystrom@google.com changed reviewers:
+ whesse@google.com

[Bob Nystrom, 2017-05-25 17:53:09]

rnystrom@google.com changed reviewers:
+ sigmund@google.com
- whesse@google.com

[Bob Nystrom, 2017-05-25 17:53:09]

Bouncing to Siggy since AAR folks are on holiday.

I know you're busy, but if you get a change, could you take a look at this?
Thanks!

[Siggi Cherem (dart-lang), 2017-05-25 21:57:19]

lgtm

https://codereview.chromium.org/2902023002/diff/1/tools/testing/dart/options....
File tools/testing/dart/options.dart (right):

https://codereview.chromium.org/2902023002/diff/1/tools/testing/dart/options....
tools/testing/dart/options.dart:154: self_check:       Pass each test or its
compiled output to every
(optional) I understand this is from before but honestly I'm not sure I followed
what this does, it felt a bit meta, is there a way we can clarify or add
examples?

https://codereview.chromium.org/2902023002/diff/1/tools/testing/dart/options....
tools/testing/dart/options.dart:227: new _Option.bool('cps_ir', 'Run the
compiler with the cps based backend.'),
I believe all uses of this flag are gone, so it is safe to remove now.

[Bob Nystrom, 2017-05-26 18:03:22]

I had to tweak some new "useDFE" code that appeared to in order to get it static
error clean again. PTAL.

https://codereview.chromium.org/2902023002/diff/1/tools/testing/dart/options....
File tools/testing/dart/options.dart (right):

https://codereview.chromium.org/2902023002/diff/1/tools/testing/dart/options....
tools/testing/dart/options.dart:154: self_check:       Pass each test or its
compiled output to every
On 2017/05/25 21:57:19, Siggi Cherem (dart-lang) wrote:
> (optional) I understand this is from before but honestly I'm not sure I
followed
> what this does, it felt a bit meta, is there a way we can clarify or add
> examples?

I honestly have no idea what this is or how it's used. :-/

https://codereview.chromium.org/2902023002/diff/1/tools/testing/dart/options....
tools/testing/dart/options.dart:227: new _Option.bool('cps_ir', 'Run the
compiler with the cps based backend.'),
On 2017/05/25 21:57:19, Siggi Cherem (dart-lang) wrote:
> I believe all uses of this flag are gone, so it is safe to remove now.

Done.

It did show up in a couple of status files, but I think they were useless.
Removed those too.

[Siggi Cherem (dart-lang), 2017-05-26 18:11:27]

lgtm

[Bob Nystrom, 2017-05-26 20:36:46]

Description was changed from

==========
Refactor test option parsing code.

This doesn’t touch the resulting configuration map, which is what this
is leading up to, but it cleans up the specification and parsing of the
options and removes a lot of redundancy.

Behavior should be the same as it was before, except that all options
now allow both their underscore-separated and hyphen-separated names.
So this is now valid:

test.py --hot_reload --append-logs

Where before, you use to have to do --hot-reload (OK) and
--append_logs (bad, since almost all other options expect hyphens).
==========

to

==========
Refactor test option parsing code.

This doesn’t touch the resulting configuration map, which is what this
is leading up to, but it cleans up the specification and parsing of the
options and removes a lot of redundancy.

Behavior should be the same as it was before, except that all options
now allow both their underscore-separated and hyphen-separated names.
So this is now valid:

test.py --hot_reload --append-logs

Where before, you use to have to do --hot-reload (OK) and
--append_logs (bad, since almost all other options expect hyphens).

R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/9c2dff8ebc9f2c53d23ae46f71cf6e3b95a0e823
==========

[Bob Nystrom, 2017-05-26 20:36:47]

Committed patchset #2 (id:20001) manually as
9c2dff8ebc9f2c53d23ae46f71cf6e3b95a0e823 (presubmit successful).