Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(461)

Unified Diff: tools/testing/dart/launch_browser.dart

Issue 2901923003: Replace the configuration map with a typed object. (Closed)
Patch Set: Revise. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/testing/dart/http_server.dart ('k') | tools/testing/dart/main.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/launch_browser.dart
diff --git a/tools/testing/dart/launch_browser.dart b/tools/testing/dart/launch_browser.dart
index 66264d93a81131ec855f236e48db1aced50640f4..23f861754bc90b18d28c8f587f635289e4603d75 100644
--- a/tools/testing/dart/launch_browser.dart
+++ b/tools/testing/dart/launch_browser.dart
@@ -10,8 +10,8 @@
* DARTBIN should be the checked in stable binary.
*/
-import "browser_controller.dart";
-import "utils.dart";
+import 'browser_controller.dart';
+import 'configuration.dart';
void printHelp() {
print("Usage pattern:");
@@ -33,7 +33,9 @@ void main(List<String> arguments) {
return;
}
- var executable = Locations.getBrowserLocation(name, {});
- var browser = new Browser.byName(name, executable);
+ var runtime = Runtime.find(name);
+ var configuration = new Configuration(runtime: runtime);
+ var executable = configuration.browserLocation;
+ var browser = new Browser.byRuntime(runtime, executable);
browser.start(arguments[1]);
}
« no previous file with comments | « tools/testing/dart/http_server.dart ('k') | tools/testing/dart/main.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698