Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Unified Diff: tools/testing/dart/expectation_set.dart

Issue 2901923003: Replace the configuration map with a typed object. (Closed)
Patch Set: Revise. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/testing/dart/environment.dart ('k') | tools/testing/dart/http_server.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/expectation_set.dart
diff --git a/tools/testing/dart/expectation_set.dart b/tools/testing/dart/expectation_set.dart
index f7d135f98beceabc9b03ced89e93080ddea90282..f2091420dec44e7c9f2118472954150f07177e65 100644
--- a/tools/testing/dart/expectation_set.dart
+++ b/tools/testing/dart/expectation_set.dart
@@ -2,6 +2,8 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
+import 'configuration.dart';
+import 'environment.dart';
import 'expectation.dart';
import 'status_file.dart';
@@ -13,9 +15,10 @@ import 'status_file.dart';
/// that happens, all of the expectations of every entry are combined.
class ExpectationSet {
/// Reads the expectations defined by the status files at [statusFilePaths]
- /// given [environment].
+ /// when in [configuration].
static ExpectationSet read(
- List<String> statusFilePaths, Map<String, dynamic> environment) {
+ List<String> statusFilePaths, Configuration configuration) {
+ var environment = new Environment(configuration);
var expectations = new ExpectationSet._();
for (var path in statusFilePaths) {
var file = new StatusFile.read(path);
« no previous file with comments | « tools/testing/dart/environment.dart ('k') | tools/testing/dart/http_server.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698