Chromium Code Reviews| Index: chrome/android/java/res/layout/translate_menu_item_checked.xml |
| diff --git a/chrome/android/java/res/layout/translate_menu_item_checked.xml b/chrome/android/java/res/layout/translate_menu_item_checked.xml |
| index cd7da1306fc43bb521665d7e496b3a5cb30469a6..51005570627b983cded3e962d4482bf4c2cf4dd8 100644 |
| --- a/chrome/android/java/res/layout/translate_menu_item_checked.xml |
| +++ b/chrome/android/java/res/layout/translate_menu_item_checked.xml |
| @@ -14,6 +14,16 @@ |
| android:layout_width="match_parent" |
| android:layout_height="?android:attr/listPreferredItemHeightSmall" > |
| + <TextView |
| + android:id="@+id/menu_item_text" |
| + android:textAppearance="?android:attr/textAppearanceLargePopupMenu" |
| + android:layout_width="0dp" |
|
mdjones
2017/05/24 16:08:00
Why does this width change to 0?
mdjones
2017/05/24 16:11:49
I guess layout weight determines the width now.
Marti Wong
2017/05/25 00:28:55
Yes, it uses weight to determine the width now.
Ot
|
| + android:layout_height="match_parent" |
| + android:layout_weight="1" |
| + android:layout_gravity="start" |
| + android:gravity="center_vertical" |
| + android:singleLine="true" |
| + android:paddingEnd="16dp" /> |
| <org.chromium.chrome.browser.widget.TintedImageView |
| android:id="@+id/menu_item_icon" |
| android:src="@drawable/ic_check_googblue_24dp" |
| @@ -22,15 +32,6 @@ |
| android:layout_gravity="end" |
| android:gravity="center_vertical" |
| chrome:tint="@color/dark_mode_tint" /> |
| - <TextView |
| - android:id="@+id/menu_item_text" |
| - android:textAppearance="?android:attr/textAppearanceLargePopupMenu" |
| - android:layout_width="wrap_content" |
| - android:layout_height="match_parent" |
| - android:layout_gravity="start" |
| - android:gravity="center_vertical" |
| - android:singleLine="true" |
| - android:paddingStart="16dp" /> |
| </LinearLayout> |