Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(650)

Unified Diff: ash/wm/overview/scoped_overview_animation_settings.h

Issue 2901903003: [ash] Cleanup of ScopedOverviewAnimationSettings (Closed)
Patch Set: [ash] Cleanup of ScopedOverviewAnimationSettings (nuked factory) Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/shell.cc ('k') | ash/wm/overview/scoped_overview_animation_settings.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/wm/overview/scoped_overview_animation_settings.h
diff --git a/ash/wm/overview/scoped_overview_animation_settings.h b/ash/wm/overview/scoped_overview_animation_settings.h
index a8898bfb45190bb587673c19781fc0d1ab9af912..4734cf8f8a6f86b443cd68f93c4b8d8956b0c696 100644
--- a/ash/wm/overview/scoped_overview_animation_settings.h
+++ b/ash/wm/overview/scoped_overview_animation_settings.h
@@ -5,18 +5,36 @@
#ifndef ASH_WM_OVERVIEW_SCOPED_OVERVIEW_ANIMATION_SETTINGS_H_
#define ASH_WM_OVERVIEW_SCOPED_OVERVIEW_ANIMATION_SETTINGS_H_
+#include <memory>
+
+#include "ash/wm/overview/overview_animation_type.h"
+#include "base/macros.h"
+
+namespace aura {
+class Window;
+} // namespace aura
+
namespace ui {
class ImplicitAnimationObserver;
+class ScopedLayerAnimationSettings;
} // namespace ui
namespace ash {
// ScopedOverviewAnimationSettings correctly configures the animation
-// settings for a WmWindow given an OverviewAnimationType.
+// settings for an aura::Window given an OverviewAnimationType.
class ScopedOverviewAnimationSettings {
public:
- virtual ~ScopedOverviewAnimationSettings() {}
- virtual void AddObserver(ui::ImplicitAnimationObserver* observer) = 0;
+ ScopedOverviewAnimationSettings(OverviewAnimationType animation_type,
+ aura::Window* window);
+ ~ScopedOverviewAnimationSettings();
+ void AddObserver(ui::ImplicitAnimationObserver* observer);
+
+ private:
+ // The managed animation settings.
+ std::unique_ptr<ui::ScopedLayerAnimationSettings> animation_settings_;
+
+ DISALLOW_COPY_AND_ASSIGN(ScopedOverviewAnimationSettings);
};
} // namespace ash
« no previous file with comments | « ash/shell.cc ('k') | ash/wm/overview/scoped_overview_animation_settings.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698