Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6660)

Unified Diff: chrome/browser/ui/browser_instant_controller_unittest.cc

Issue 2901833002: Create NavigationHandle after beforeunload with PlzNavigate. (Closed)
Patch Set: small fix from jam Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/browser_instant_controller_unittest.cc
diff --git a/chrome/browser/ui/browser_instant_controller_unittest.cc b/chrome/browser/ui/browser_instant_controller_unittest.cc
index 0db9e7e2fd695bb852227c11cf1ae0d601cd1d82..7d87d7acb178c38d8ec3bd2bd1e9203688f5cc81 100644
--- a/chrome/browser/ui/browser_instant_controller_unittest.cc
+++ b/chrome/browser/ui/browser_instant_controller_unittest.cc
@@ -81,21 +81,9 @@ class FakeWebContentsObserver : public content::WebContentsObserver {
url_(contents->GetURL()),
num_reloads_(0) {}
- void DidStartNavigation(
- content::NavigationHandle* navigation_handle) override {
- if (!content::IsBrowserSideNavigationEnabled())
- return;
- if (url_ == navigation_handle->GetURL())
- num_reloads_++;
- current_url_ = navigation_handle->GetURL();
- }
-
- // TODO: remove this method when PlzNavigate is turned on by default.
void DidStartNavigationToPendingEntry(
const GURL& url,
content::ReloadType reload_type) override {
- if (content::IsBrowserSideNavigationEnabled())
- return;
if (url_ == url)
num_reloads_++;
current_url_ = url;
« no previous file with comments | « chrome/browser/ui/browser_browsertest.cc ('k') | content/browser/devtools/protocol/devtools_protocol_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698