Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Unified Diff: content/browser/web_contents/aura/overscroll_navigation_overlay_unittest.cc

Issue 2901833002: Create NavigationHandle after beforeunload with PlzNavigate. (Closed)
Patch Set: Rewrote BeforeUnload test Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/web_contents/aura/overscroll_navigation_overlay_unittest.cc
diff --git a/content/browser/web_contents/aura/overscroll_navigation_overlay_unittest.cc b/content/browser/web_contents/aura/overscroll_navigation_overlay_unittest.cc
index d46238d169665c8c4ccec51399972738ccac9af9..78c5e8bea4bc188d58d7b029fed2889bf1b94f5a 100644
--- a/content/browser/web_contents/aura/overscroll_navigation_overlay_unittest.cc
+++ b/content/browser/web_contents/aura/overscroll_navigation_overlay_unittest.cc
@@ -55,22 +55,11 @@ class ImmediateLoadObserver : WebContentsObserver {
}
~ImmediateLoadObserver() override {}
- // TODO: remove this method when PlzNavigate is turned on by default.
void DidStartNavigationToPendingEntry(const GURL& url,
ReloadType reload_type) override {
- if (!IsBrowserSideNavigationEnabled()) {
- // Simulate immediate web page load.
- contents_->TestSetIsLoading(false);
- Observe(nullptr);
- }
- }
-
- void DidStartNavigation(NavigationHandle* navigation_handlee) override {
- if (IsBrowserSideNavigationEnabled()) {
- // Simulate immediate web page load.
- contents_->TestSetIsLoading(false);
- Observe(nullptr);
- }
+ // Simulate immediate web page load.
+ contents_->TestSetIsLoading(false);
+ Observe(nullptr);
}
private:

Powered by Google App Engine
This is Rietveld 408576698