Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Side by Side Diff: content/browser/frame_host/navigator_impl.h

Issue 2901833002: Create NavigationHandle after beforeunload with PlzNavigate. (Closed)
Patch Set: small fix from jam Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/browser/frame_host/navigator.h ('k') | content/browser/frame_host/navigator_impl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_IMPL_H_ 5 #ifndef CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_IMPL_H_
6 #define CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_IMPL_H_ 6 #define CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_IMPL_H_
7 7
8 #include <memory> 8 #include <memory>
9 9
10 #include "base/macros.h" 10 #include "base/macros.h"
(...skipping 67 matching lines...) Expand 10 before | Expand all | Expand 10 after
78 const GURL& url, 78 const GURL& url,
79 SiteInstance* source_site_instance, 79 SiteInstance* source_site_instance,
80 const std::vector<GURL>& redirect_chain, 80 const std::vector<GURL>& redirect_chain,
81 const Referrer& referrer, 81 const Referrer& referrer,
82 ui::PageTransition page_transition, 82 ui::PageTransition page_transition,
83 const GlobalRequestID& transferred_global_request_id, 83 const GlobalRequestID& transferred_global_request_id,
84 bool should_replace_current_entry, 84 bool should_replace_current_entry,
85 const std::string& method, 85 const std::string& method,
86 scoped_refptr<ResourceRequestBodyImpl> post_body, 86 scoped_refptr<ResourceRequestBodyImpl> post_body,
87 const std::string& extra_headers) override; 87 const std::string& extra_headers) override;
88 void OnBeforeUnloadACK(FrameTreeNode* frame_tree_node, bool proceed) override; 88 void OnBeforeUnloadACK(FrameTreeNode* frame_tree_node,
89 bool proceed,
90 const base::TimeTicks& proceed_time) override;
89 void OnBeginNavigation(FrameTreeNode* frame_tree_node, 91 void OnBeginNavigation(FrameTreeNode* frame_tree_node,
90 const CommonNavigationParams& common_params, 92 const CommonNavigationParams& common_params,
91 const BeginNavigationParams& begin_params) override; 93 const BeginNavigationParams& begin_params) override;
92 void OnAbortNavigation(FrameTreeNode* frame_tree_node) override; 94 void OnAbortNavigation(FrameTreeNode* frame_tree_node) override;
93 void LogResourceRequestTime(base::TimeTicks timestamp, 95 void LogResourceRequestTime(base::TimeTicks timestamp,
94 const GURL& url) override; 96 const GURL& url) override;
95 void LogBeforeUnloadTime( 97 void LogBeforeUnloadTime(
96 const base::TimeTicks& renderer_before_unload_start_time, 98 const base::TimeTicks& renderer_before_unload_start_time,
97 const base::TimeTicks& renderer_before_unload_end_time) override; 99 const base::TimeTicks& renderer_before_unload_end_time) override;
98 void CancelNavigation(FrameTreeNode* frame_tree_node, 100 void CancelNavigation(FrameTreeNode* frame_tree_node,
99 bool inform_renderer) override; 101 bool inform_renderer) override;
100 void DiscardPendingEntryIfNeeded(NavigationHandleImpl* handle) override; 102 void DiscardPendingEntryIfNeeded(int expected_pending_entry_id) override;
101 103
102 private: 104 private:
103 // Holds data used to track browser side navigation metrics. 105 // Holds data used to track browser side navigation metrics.
104 struct NavigationMetricsData; 106 struct NavigationMetricsData;
105 107
106 friend class NavigatorTestWithBrowserSideNavigation; 108 friend class NavigatorTestWithBrowserSideNavigation;
107 ~NavigatorImpl() override; 109 ~NavigatorImpl() override;
108 110
109 // Navigates to the given entry, which might be the pending entry (if 111 // Navigates to the given entry, which might be the pending entry (if
110 // |is_pending_entry| is true). Private because all callers should use either 112 // |is_pending_entry| is true). Private because all callers should use either
(...skipping 48 matching lines...) Expand 10 before | Expand all | Expand 10 after
159 NavigatorDelegate* delegate_; 161 NavigatorDelegate* delegate_;
160 162
161 std::unique_ptr<NavigatorImpl::NavigationMetricsData> navigation_data_; 163 std::unique_ptr<NavigatorImpl::NavigationMetricsData> navigation_data_;
162 164
163 DISALLOW_COPY_AND_ASSIGN(NavigatorImpl); 165 DISALLOW_COPY_AND_ASSIGN(NavigatorImpl);
164 }; 166 };
165 167
166 } // namespace content 168 } // namespace content
167 169
168 #endif // CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_IMPL_H_ 170 #endif // CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_IMPL_H_
OLDNEW
« no previous file with comments | « content/browser/frame_host/navigator.h ('k') | content/browser/frame_host/navigator_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698