Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(566)

Issue 2901823002: Type .targetElement as MemberEntity (Closed)

Created:
3 years, 7 months ago by Johnni Winther
Modified:
3 years, 7 months ago
CC:
reviews_dartlang.org, Emily Fortuna
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Type .targetElement as MemberEntity + decouple LocalsHandler from ExecutableElement R=efortuna@google.com Committed: https://github.com/dart-lang/sdk/commit/ac07b3ce03ba210d82ca42826250bd81f5202f85

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -35 lines) Patch
M pkg/compiler/lib/src/elements/elements.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 4 chunks +17 lines, -10 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder_kernel.dart View 4 chunks +5 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/ssa/graph_builder.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart View 4 chunks +6 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/ssa/locals_handler.dart View 7 chunks +16 lines, -10 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Johnni Winther
3 years, 7 months ago (2017-05-23 14:05:20 UTC) #2
Emily Fortuna
lgtm
3 years, 7 months ago (2017-05-23 17:28:34 UTC) #4
Johnni Winther
3 years, 7 months ago (2017-05-24 08:23:43 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ac07b3ce03ba210d82ca42826250bd81f5202f85 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698