Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Unified Diff: ios/chrome/browser/ui/bookmarks/bookmark_signin_promo_cell.mm

Issue 2901783002: Adding accessibility to the close button in sign-in promo (Closed)
Patch Set: . Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/chrome/browser/ui/bookmarks/bookmark_signin_promo_cell.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/ui/bookmarks/bookmark_signin_promo_cell.mm
diff --git a/ios/chrome/browser/ui/bookmarks/bookmark_signin_promo_cell.mm b/ios/chrome/browser/ui/bookmarks/bookmark_signin_promo_cell.mm
index edf209f874ca54fdaa99eb4334d3301e6873fe0a..e5df703f82a7146ca24eda3eab4df43709ad7190 100644
--- a/ios/chrome/browser/ui/bookmarks/bookmark_signin_promo_cell.mm
+++ b/ios/chrome/browser/ui/bookmarks/bookmark_signin_promo_cell.mm
@@ -13,11 +13,6 @@
#error "This file requires ARC support."
#endif
-namespace {
-// Close button size.
-const CGFloat kCloseButtonSize = 24;
-}
-
@implementation BookmarkSigninPromoCell {
SigninPromoView* _signinPromoView;
UIButton* _closeButton;
@@ -43,19 +38,10 @@ const CGFloat kCloseButtonSize = 24;
[contentView addSubview:_signinPromoView];
AddSameConstraints(_signinPromoView, contentView);
- _closeButton = [[UIButton alloc]
- initWithFrame:CGRectMake(0, 0, kCloseButtonSize, kCloseButtonSize)];
- [_closeButton addTarget:self
- action:@selector(closeButtonAction:)
- forControlEvents:UIControlEventTouchUpInside];
- _closeButton.translatesAutoresizingMaskIntoConstraints = NO;
- [contentView addSubview:_closeButton];
- [_closeButton setImage:[UIImage imageNamed:@"signin_promo_close_gray"]
- forState:UIControlStateNormal];
- NSArray* buttonVisualConstraints =
- @[ @"H:[closeButton]-|", @"V:|-[closeButton]" ];
- NSDictionary* views = @{ @"closeButton" : _closeButton };
- ApplyVisualConstraints(buttonVisualConstraints, views);
+ _signinPromoView.closeButton.hidden = NO;
+ [_signinPromoView.closeButton addTarget:self
+ action:@selector(closeButtonAction:)
+ forControlEvents:UIControlEventTouchUpInside];
_signinPromoView.backgroundColor = [UIColor whiteColor];
_signinPromoView.textLabel.text =
@@ -82,9 +68,8 @@ const CGFloat kCloseButtonSize = 24;
}
- (void)closeButtonAction:(id)sender {
- if (_closeButtonAction) {
- _closeButtonAction();
- }
+ DCHECK(_closeButtonAction);
+ _closeButtonAction();
}
@end
« no previous file with comments | « ios/chrome/browser/ui/bookmarks/bookmark_signin_promo_cell.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698