Adding accessibility to the close button in sign-in promo

ios/chrome/browser/ui/bookmarks/bookmark_signin_promo_cell.mm

Index: ios/chrome/browser/ui/bookmarks/bookmark_signin_promo_cell.mm
diff --git a/ios/chrome/browser/ui/bookmarks/bookmark_signin_promo_cell.mm b/ios/chrome/browser/ui/bookmarks/bookmark_signin_promo_cell.mm
index edf209f874ca54fdaa99eb4334d3301e6873fe0a..8667f2301e7f114946b9bc02cd916b61fd57bffc 100644
--- a/ios/chrome/browser/ui/bookmarks/bookmark_signin_promo_cell.mm
+++ b/ios/chrome/browser/ui/bookmarks/bookmark_signin_promo_cell.mm
@@ -4,6 +4,7 @@
 
 #import "ios/chrome/browser/ui/bookmarks/bookmark_signin_promo_cell.h"
 
+#import "MDCFlatButton.h"

[lpromero, 2017/05/23 12:06:16]

This works? Weird.
#import "ios/third_party/.../MaterialButtons.h"

[jlebel, 2017/05/23 12:43:26]

Done.

 #import "ios/chrome/browser/ui/authentication/signin_promo_view.h"
 #import "ios/chrome/browser/ui/uikit_ui_util.h"
 #include "ios/chrome/grit/ios_chromium_strings.h"
@@ -13,11 +14,6 @@
 #error "This file requires ARC support."
 #endif
 
-namespace {
-// Close button size.
-const CGFloat kCloseButtonSize = 24;
-}
-
 @implementation BookmarkSigninPromoCell {
   SigninPromoView* _signinPromoView;
   UIButton* _closeButton;
@@ -43,19 +39,17 @@ const CGFloat kCloseButtonSize = 24;
     [contentView addSubview:_signinPromoView];
     AddSameConstraints(_signinPromoView, contentView);
 
-    _closeButton = [[UIButton alloc]
-        initWithFrame:CGRectMake(0, 0, kCloseButtonSize, kCloseButtonSize)];
-    [_closeButton addTarget:self
-                     action:@selector(closeButtonAction:)
-           forControlEvents:UIControlEventTouchUpInside];
-    _closeButton.translatesAutoresizingMaskIntoConstraints = NO;
-    [contentView addSubview:_closeButton];
-    [_closeButton setImage:[UIImage imageNamed:@"signin_promo_close_gray"]
-                  forState:UIControlStateNormal];
-    NSArray* buttonVisualConstraints =
-        @[ @"H:[closeButton]-|", @"V:|-[closeButton]" ];
-    NSDictionary* views = @{ @"closeButton" : _closeButton };
-    ApplyVisualConstraints(buttonVisualConstraints, views);
+    [_signinPromoView.closeButton addTarget:self
+                                     action:@selector(closeButtonAction:)
+                           forControlEvents:UIControlEventTouchUpInside];
+    _signinPromoView.closeButton.hidden = NO;
+    //    [_signinPromoView addSubview:_closeButton];

[lpromero, 2017/05/23 12:06:16]

Please clean up. 

[jlebel, 2017/05/23 12:43:26]

Done.

+    //    [_closeButton setImage:[UIImage imageNamed:@"signin_promo_close_gray"]
+    //                  forState:UIControlStateNormal];
+    //    NSArray* buttonVisualConstraints =
+    //        @[ @"H:[closeButton]-|", @"V:|-[closeButton]" ];
+    //    NSDictionary* views = @{ @"closeButton" : _closeButton };
+    //    ApplyVisualConstraints(buttonVisualConstraints, views);
 
     _signinPromoView.backgroundColor = [UIColor whiteColor];
     _signinPromoView.textLabel.text =