media/video/video_decode_accelerator.h - Issue 2901753002: Make VDA::Config's converting constructor explicit

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/video/video_decode_accelerator.h

Issue 2901753002: Make VDA::Config's converting constructor explicit (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/video/video_decode_accelerator.h

diff --git a/media/video/video_decode_accelerator.h b/media/video/video_decode_accelerator.h

index 6fe0573fd0bbc24eb23506616c87ef40bdb19fa8..4f71db35925430198af93a515382f47b0b965bd4 100644

--- a/media/video/video_decode_accelerator.h

+++ b/media/video/video_decode_accelerator.h

@@ -131,8 +131,7 @@ class MEDIA_EXPORT VideoDecodeAccelerator {

Config(const Config& config);

// Intentional converting constructor.

watk 2017/05/23 17:13:40 Please delete this comment now

Chandan 2017/05/24 13:54:04 Done.

- // TODO(watk): Make this explicit.

- Config(VideoCodecProfile profile);

+ explicit Config(VideoCodecProfile profile);

~Config();

« no previous file with comments | « media/gpu/video_decode_accelerator_unittest.cc ('k') | no next file » | no next file with comments »