Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 2901733002: Revert "With this change 'tools/test.py -cdartk vm' will run vm tests with Dart Frontend parser." (Closed)

Created:
3 years, 7 months ago by aam
Modified:
3 years, 7 months ago
Reviewers:
siva
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "With this change 'tools/test.py -cdartk vm' will run vm tests with Dart Frontend parser." This reverts commit f62a2a95629f2f186851eeaf1888826b12d4968c. Commit above [expectedly] broke runtime/vm tests since it uses DFE instead of vm parser, but I didn't realize we actually test -cdartk configuration. This has to be resubmitted with status file update to mark 235 vm tests failing with DFE. TBR=siva BUG= Committed: https://github.com/dart-lang/sdk/commit/e0cdea811a368d6aa53e31741bc027fd48106448

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -8 lines) Patch
M tools/testing/dart/test_configurations.dart View 1 chunk +1 line, -2 lines 0 comments Download
M tools/testing/dart/test_suite.dart View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
aam
3 years, 7 months ago (2017-05-23 02:43:00 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e0cdea811a368d6aa53e31741bc027fd48106448 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698