Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(450)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 290173011: Cleanup: Use base::CommandLine in remoting/ (Closed)

Created:
6 years, 7 months ago by Lei Zhang
Modified:
6 years, 7 months ago
Reviewers:
garykac
CC:
chromium-reviews, chromoting-reviews_chromium.org
Visibility:
Public.

Description

Cleanup: Use base::CommandLine in remoting/ Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272455

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -60 lines) Patch
M remoting/client/jni/chromoting_jni_runtime.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/daemon_process.cc View 1 chunk +2 lines, -1 line 0 comments Download
M remoting/host/desktop_process_main.cc View 1 chunk +2 lines, -1 line 0 comments Download
M remoting/host/desktop_resizer_linux.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/host/host_main.cc View 3 chunks +14 lines, -10 lines 0 comments Download
M remoting/host/it2me/it2me_native_messaging_host_main.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/plugin/host_plugin.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M remoting/host/remoting_me2me_host.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M remoting/host/service_urls.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/setup/daemon_controller_delegate_linux.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M remoting/host/setup/me2me_native_messaging_host.cc View 1 chunk +10 lines, -7 lines 0 comments Download
M remoting/host/setup/me2me_native_messaging_host_main.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M remoting/host/setup/start_host.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M remoting/host/usage_stats_consent_mac.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/win/host_service.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M remoting/host/win/launch_process_with_token.cc View 5 chunks +6 lines, -7 lines 0 comments Download
M remoting/host/win/unprivileged_process_delegate.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/host/win/wts_session_process_delegate.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/tools/breakpad_tester_win.cc View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Lei Zhang
6 years, 7 months ago (2014-05-22 20:56:09 UTC) #1
garykac
lgtm
6 years, 7 months ago (2014-05-22 21:19:41 UTC) #2
garykac
The CQ bit was checked by garykac@chromium.org
6 years, 7 months ago (2014-05-22 21:19:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/290173011/1
6 years, 7 months ago (2014-05-22 21:22:02 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-23 09:42:05 UTC) #5
Message was sent while issue was closed. 
Change committed as 272455

Powered by Google App Engine
This is Rietveld 408576698