Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Unified Diff: third_party/WebKit/Source/core/editing/iterators/TextIterator.h

Issue 2901713002: Add TextIterator::HandlePreFormattedTextNode to wrap relevant logic (Closed)
Patch Set: Tue May 23 22:08:24 PDT 2017 Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/iterators/TextIterator.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/editing/iterators/TextIterator.h
diff --git a/third_party/WebKit/Source/core/editing/iterators/TextIterator.h b/third_party/WebKit/Source/core/editing/iterators/TextIterator.h
index 86efdcbbdd633f36861edb6af42683d5e653a1ff..dd19dbf72b4df990c251a15ea15d49f2aff134f9 100644
--- a/third_party/WebKit/Source/core/editing/iterators/TextIterator.h
+++ b/third_party/WebKit/Source/core/editing/iterators/TextIterator.h
@@ -134,9 +134,17 @@ class CORE_TEMPLATE_CLASS_EXPORT TextIteratorAlgorithm {
bool ShouldRepresentNodeOffsetZero();
bool ShouldEmitSpaceBeforeAndAfterNode(Node*);
void RepresentNodeOffsetZero();
+
+ // Return true if the iteration progress should advance to |kHandledNode|
+ // after calling a |HandleXXX| function.
+ // TODO(xiaochengh): The meaning of the return values is unclear, and they do
+ // not always clearly control the iteration progress. Should consider removing
+ // the return values and control the iteration in a cleaner way.
bool HandleTextNode();
+ bool HandlePreFormattedTextNode();
bool HandleReplacedElement();
bool HandleNonTextNode();
+
void HandleTextBox();
void HandleTextNodeFirstLetter(LayoutTextFragment*);
bool ShouldHandleFirstLetter(const LayoutText&) const;
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/iterators/TextIterator.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698