Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 2901693002: CHECK failure in gpu::GpuVSyncWorker::OpenAdapter and UMA for error codes (Closed)

Created:
3 years, 7 months ago by stanisc
Modified:
3 years, 7 months ago
Reviewers:
rkaplow, jbauman
CC:
chromium-reviews, piman+watch_chromium.org, asvitkine+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

CHECK failure in gpu::GpuVSyncWorker::OpenAdapter and UMA for error codes The previous fix (see crrev.com/2883683002) was insufficient. It looks like there is at least one more possible error code returned from OpenAdapter - STATUS_UNSUCCESSFUL. It should be better to just cover all possible error codes and fallback to delay based v-sync for any reason. Additionally, as discussed in CR for the previous fix, I've added an UMA histogram for tracking how many GPU v-sync cycles end up failing for one of 3 different reasons vs. the number of successful v-sync cycles. BUG=721521 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2901693002 Cr-Commit-Position: refs/heads/master@{#474406} Committed: https://chromium.googlesource.com/chromium/src/+/c76c0fd5ab7540ba6d28ea16b0ad305b086d55c5

Patch Set 1 #

Total comments: 4

Patch Set 2 : Addressed CR feedback #

Total comments: 2

Patch Set 3 : Single entrypoint to UMA_HISTOGRAM_ENUMERATION #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -12 lines) Patch
M gpu/ipc/service/gpu_vsync_provider_win.cc View 1 2 10 chunks +30 lines, -12 lines 0 comments Download
M tools/metrics/histograms/enums.xml View 1 chunk +7 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 25 (18 generated)
stanisc
PTAL!
3 years, 7 months ago (2017-05-23 00:06:33 UTC) #6
jbauman
lgtm with a couple of nits. https://codereview.chromium.org/2901693002/diff/20001/gpu/ipc/service/gpu_vsync_provider_win.cc File gpu/ipc/service/gpu_vsync_provider_win.cc (right): https://codereview.chromium.org/2901693002/diff/20001/gpu/ipc/service/gpu_vsync_provider_win.cc#newcode80 gpu/ipc/service/gpu_vsync_provider_win.cc:80: enum WaitForVBlankErrorCode { ...
3 years, 7 months ago (2017-05-23 00:15:41 UTC) #7
stanisc
+ rkaplow@chromium.org for histograms.xml. https://codereview.chromium.org/2901693002/diff/20001/gpu/ipc/service/gpu_vsync_provider_win.cc File gpu/ipc/service/gpu_vsync_provider_win.cc (right): https://codereview.chromium.org/2901693002/diff/20001/gpu/ipc/service/gpu_vsync_provider_win.cc#newcode80 gpu/ipc/service/gpu_vsync_provider_win.cc:80: enum WaitForVBlankErrorCode { On 2017/05/23 ...
3 years, 7 months ago (2017-05-23 01:16:32 UTC) #9
rkaplow
lgtm https://codereview.chromium.org/2901693002/diff/40001/gpu/ipc/service/gpu_vsync_provider_win.cc File gpu/ipc/service/gpu_vsync_provider_win.cc (right): https://codereview.chromium.org/2901693002/diff/40001/gpu/ipc/service/gpu_vsync_provider_win.cc#newcode421 gpu/ipc/service/gpu_vsync_provider_win.cc:421: UMA_HISTOGRAM_ENUMERATION("GPU.WaitForVBlankErrorCode", error_code, it's generally best when there's only ...
3 years, 7 months ago (2017-05-24 15:44:36 UTC) #14
stanisc
https://codereview.chromium.org/2901693002/diff/40001/gpu/ipc/service/gpu_vsync_provider_win.cc File gpu/ipc/service/gpu_vsync_provider_win.cc (right): https://codereview.chromium.org/2901693002/diff/40001/gpu/ipc/service/gpu_vsync_provider_win.cc#newcode421 gpu/ipc/service/gpu_vsync_provider_win.cc:421: UMA_HISTOGRAM_ENUMERATION("GPU.WaitForVBlankErrorCode", error_code, On 2017/05/24 15:44:36, rkaplow wrote: > it's ...
3 years, 7 months ago (2017-05-24 18:11:11 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2901693002/60001
3 years, 7 months ago (2017-05-24 20:35:29 UTC) #22
commit-bot: I haz the power
3 years, 7 months ago (2017-05-24 20:41:18 UTC) #25
Message was sent while issue was closed.
Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/c76c0fd5ab7540ba6d28ea16b0ad...

Powered by Google App Engine
This is Rietveld 408576698