Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Unified Diff: chrome/browser/devtools/devtools_sanity_browsertest.cc

Issue 2901583002: Fold AppModalDialog into its only subclass, JavaScriptAppModalDialog. (Closed)
Patch Set: fix collapse Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/alert_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/devtools/devtools_sanity_browsertest.cc
diff --git a/chrome/browser/devtools/devtools_sanity_browsertest.cc b/chrome/browser/devtools/devtools_sanity_browsertest.cc
index 5ac3e8a1a178a9d308175d0198a892330d74f20f..fb8514f174b95a9420458498ad02ea291f3e3b83 100644
--- a/chrome/browser/devtools/devtools_sanity_browsertest.cc
+++ b/chrome/browser/devtools/devtools_sanity_browsertest.cc
@@ -87,7 +87,6 @@
#include "ui/gl/gl_switches.h"
#include "url/gurl.h"
-using app_modal::AppModalDialog;
using app_modal::JavaScriptAppModalDialog;
using app_modal::NativeAppModalDialog;
using content::BrowserThread;
@@ -452,11 +451,8 @@ class DevToolsBeforeUnloadTest: public DevToolsSanityTest {
}
NativeAppModalDialog* GetDialog() {
- AppModalDialog* dialog = ui_test_utils::WaitForAppModalDialog();
- EXPECT_TRUE(dialog->IsJavaScriptModalDialog());
- JavaScriptAppModalDialog* js_dialog =
- static_cast<JavaScriptAppModalDialog*>(dialog);
- NativeAppModalDialog* native_dialog = js_dialog->native_dialog();
+ JavaScriptAppModalDialog* dialog = ui_test_utils::WaitForAppModalDialog();
+ NativeAppModalDialog* native_dialog = dialog->native_dialog();
EXPECT_TRUE(native_dialog);
return native_dialog;
}
« no previous file with comments | « no previous file | chrome/browser/extensions/alert_apitest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698