Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(765)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: chrome/common/pdf_uma.cc
Issue
2901563003
:
PDF: Add UMA to track embedded PDF triggered drive-by downloads. (Closed)
Patch Set: remove stray comment
Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
chrome/browser/download/chrome_download_manager_delegate.cc
chrome/common/BUILD.gn
chrome/common/pdf_uma.h
chrome/common/pdf_uma.cc
chrome/renderer/chrome_content_renderer_client.cc
chrome/renderer/plugins/plugin_uma.h
chrome/renderer/plugins/plugin_uma.cc
tools/metrics/histograms/enums.xml
View unified diff
|
Download patch
« chrome/common/pdf_uma.h
('K') |
« chrome/common/pdf_uma.h
('k') |
chrome/renderer/chrome_content_renderer_client.cc »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
// Copyright 2016 The Chromium Authors. All rights reserved.
2
// Use of this source code is governed by a BSD-style license that can be
3
// found in the LICENSE file.
4
5
#include "chrome/common/pdf_uma.h"
6
7
#include "base/metrics/histogram_macros.h"
8
9
void ReportPDFLoadStatus(PDFLoadStatus status) {
10
UMA_HISTOGRAM_ENUMERATION("PDF.LoadStatus", status,
11
PDFLoadStatus::PDF_LOAD_STATUS_COUNT);
12
}
OLD
NEW
« chrome/common/pdf_uma.h
('K') |
« chrome/common/pdf_uma.h
('k') |
chrome/renderer/chrome_content_renderer_client.cc »
('j') |
no next file with comments »
Issue 2901563003: PDF: Add UMA to track embedded PDF triggered drive-by downloads. (Closed)
Created 3 years, 7 months ago by tommycli
Modified 3 years, 7 months ago
Reviewers: Ilya Sherman, asanka, Lei Zhang
Base URL:
Comments: 17
This is Rietveld
408576698
Chromium Code Reviews
Issue 2901563003:
PDF: Add UMA to track embedded PDF triggered drive-by downloads. (Closed)
