Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Side by Side Diff: chrome/common/BUILD.gn

Issue 2901563003: PDF: Add UMA to track embedded PDF triggered drive-by downloads. (Closed)
Patch Set: remove stray comment Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/buildflag_header.gni") 5 import("//build/buildflag_header.gni")
6 import("//build/util/process_version.gni") 6 import("//build/util/process_version.gni")
7 import("//chrome/common/features.gni") 7 import("//chrome/common/features.gni")
8 import("//chrome/process_version_rc_template.gni") # For branding_file_path. 8 import("//chrome/process_version_rc_template.gni") # For branding_file_path.
9 import("//extensions/features/features.gni") 9 import("//extensions/features/features.gni")
10 import("//mojo/public/tools/bindings/mojom.gni") 10 import("//mojo/public/tools/bindings/mojom.gni")
(...skipping 451 matching lines...) Expand 10 before | Expand all | Expand 10 after
462 } 462 }
463 463
464 if (is_mac) { 464 if (is_mac) {
465 sources -= [ "channel_info_posix.cc" ] 465 sources -= [ "channel_info_posix.cc" ]
466 public_deps += [ 466 public_deps += [
467 "//third_party/google_toolbox_for_mac", 467 "//third_party/google_toolbox_for_mac",
468 "//third_party/mach_override", 468 "//third_party/mach_override",
469 ] 469 ]
470 } 470 }
471 471
472 if (enable_pdf) {
Lei Zhang 2017/05/24 22:39:21 You are using BUILDFLAG(ENABLE_PLUGINS) in the C++
tommycli 2017/05/25 18:16:37 Actually i have no idea what i was thinking. i spe
473 sources += [
474 "pdf_uma.cc",
475 "pdf_uma.h",
476 ]
477 }
472 if (enable_plugins) { 478 if (enable_plugins) {
473 sources += [ 479 sources += [
474 "pepper_flash.cc", 480 "pepper_flash.cc",
475 "pepper_flash.h", 481 "pepper_flash.h",
476 "plugin_utils.cc", 482 "plugin_utils.cc",
477 "plugin_utils.h", 483 "plugin_utils.h",
478 "ppapi_utils.cc", 484 "ppapi_utils.cc",
479 "ppapi_utils.h", 485 "ppapi_utils.h",
480 ] 486 ]
481 public_deps += [ "//third_party/adobe/flash:flapper_version_h" ] 487 public_deps += [ "//third_party/adobe/flash:flapper_version_h" ]
(...skipping 265 matching lines...) Expand 10 before | Expand all | Expand 10 after
747 753
748 mojom("page_load_metrics_mojom") { 754 mojom("page_load_metrics_mojom") {
749 sources = [ 755 sources = [
750 "page_load_metrics/page_load_metrics.mojom", 756 "page_load_metrics/page_load_metrics.mojom",
751 ] 757 ]
752 758
753 public_deps = [ 759 public_deps = [
754 "//mojo/common:common_custom_types", 760 "//mojo/common:common_custom_types",
755 ] 761 ]
756 } 762 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698