PDF: Add UMA to track embedded PDF triggered drive-by downloads.

chrome/renderer/chrome_content_renderer_client.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/chrome_content_renderer_client.h"
 
 #include <memory>
 #include <utility>
 
 #include "base/bind.h"
@@ skipping 128 matching lines @@
 #if BUILDFLAG(ENABLE_EXTENSIONS)
 #include "chrome/common/extensions/chrome_extensions_client.h"
 #include "chrome/renderer/extensions/chrome_extensions_renderer_client.h"
 #include "extensions/common/extension_urls.h"
 #include "extensions/common/switches.h"
 #include "extensions/renderer/dispatcher.h"
 #include "extensions/renderer/renderer_extension_registry.h"
 #endif
 
 #if BUILDFLAG(ENABLE_PLUGINS)
+#include "chrome/common/pdf_uma.h"

[tommycli, 2017/05/25 18:16:38]

I'm leaving these usages ENABLE_PLUGINS for now, but will add the android
(NonLoadablePlaceholder) calls in a separate CL, where i'll make this outside of
ENABLE_PLUGINS.

[Lei Zhang, 2017/05/25 21:11:08]

Is that why pdf_uma* are in the general file list in chrome/common/BUILD.gn, and
not in the if (enable_plugins) section?

[tommycli, 2017/05/25 21:20:48]

Yes exactly. And in chrome_download_manager_delegate, we use them even if
plugins is off too.

 #include "chrome/common/plugin_utils.h"
 #include "chrome/renderer/plugins/chrome_plugin_placeholder.h"
 #include "chrome/renderer/plugins/power_saver_info.h"
 #else
 #include "components/plugins/renderer/plugin_placeholder.h"
 #endif
 
 #if BUILDFLAG(ENABLE_PRINTING)
 #include "chrome/renderer/printing/chrome_print_web_view_helper_delegate.h"
 #include "components/printing/renderer/print_web_view_helper.h"
@@ skipping 658 matching lines @@
 
         // Report PDF load metrics. Since the PDF plugin is comprised of an
         // extension that loads a second plugin, avoid double counting by
         // ignoring the creation of the second plugin.
         if (info.name == ASCIIToUTF16(ChromeContentClient::kPDFPluginName) &&
             GURL(frame->GetDocument().Url()).host_piece() !=
                 extension_misc::kPdfExtensionId) {
           bool is_main_frame_plugin_document =
               render_frame->IsMainFrame() &&
               render_frame->GetWebFrame()->GetDocument().IsPluginDocument();
-          PluginUMAReporter::ReportPDFLoadStatus(
+          ReportPDFLoadStatus(
               is_main_frame_plugin_document
-                  ? PluginUMAReporter::LOADED_FULL_PAGE_PDF_WITH_PDFIUM
-                  : PluginUMAReporter::LOADED_EMBEDDED_PDF_WITH_PDFIUM);
+                  ? PDFLoadStatus::kLoadedFullPagePdfWithPdfium
+                  : PDFLoadStatus::kLoadedEmbeddedPdfWithPdfium);
         }
 
         // Delay loading plugins if prerendering.
         // TODO(mmenke):  In the case of prerendering, feed into
         //                ChromeContentRendererClient::CreatePlugin instead, to
         //                reduce the chance of future regressions.
         bool is_prerendering =
             prerender::PrerenderHelper::IsPrerendering(render_frame);
 
         bool power_saver_setting_on =
@@ skipping 23 matching lines @@
           break;
         }
 
         // Same-origin and whitelisted-origin plugins skip the placeholder.
         return render_frame->CreatePlugin(info, params, nullptr);
       }
       case ChromeViewHostMsg_GetPluginInfo_Status::kDisabled: {
         PluginUMAReporter::GetInstance()->ReportPluginDisabled(orig_mime_type,
                                                                url);
         if (info.name == ASCIIToUTF16(ChromeContentClient::kPDFPluginName)) {
-          PluginUMAReporter::ReportPDFLoadStatus(
-              PluginUMAReporter::
-                  SHOWED_DISABLED_PLUGIN_PLACEHOLDER_FOR_EMBEDDED_PDF);
+          ReportPDFLoadStatus(
+              PDFLoadStatus::kShowedDisabledPluginPlaceholderForEmbeddedPdf);
         }
 
         placeholder = create_blocked_plugin(
             IDR_DISABLED_PLUGIN_HTML,
             l10n_util::GetStringFUTF16(IDS_PLUGIN_DISABLED, group_name));
         break;
       }
       case ChromeViewHostMsg_GetPluginInfo_Status::kFlashHiddenPreferHtml: {
         placeholder = create_blocked_plugin(
             IDR_PREFER_HTML_PLUGIN_HTML,
@@ skipping 684 matching lines @@
 
   RecordYouTubeRewriteUMA(result);
   return corrected_url.ReplaceComponents(r);
 }
 
 std::unique_ptr<base::TaskScheduler::InitParams>
 ChromeContentRendererClient::GetTaskSchedulerInitParams() {
   return task_scheduler_util::
       GetRendererTaskSchedulerInitParamsFromCommandLine();
 }