chrome/common/pdf_uma.h - Issue 2901563003: PDF: Add UMA to track embedded PDF triggered drive-by downloads.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/common/pdf_uma.h

Issue 2901563003: PDF: Add UMA to track embedded PDF triggered drive-by downloads. (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_COMMON_PDF_UMA_H_

	6 #define CHROME_COMMON_PDF_UMA_H_

	7

	8 #include "base/macros.h"

	9 #include "url/gurl.h"
	Ilya Sherman 2017/05/22 23:00:42 nit: Where are these used? nit: Where are these used? tommycli 2017/05/23 00:31:59 Done. Show quoted text On 2017/05/22 23:00:42, Ilya Sherman wrote: > nit: Where are these used? Done.
	10

	11 // Must be kept in sync with PDFLoadStatus enum in histograms.xml.

	12 // This enum should be treated as append-only.

	13 enum PDFLoadStatus {
	Ilya Sherman 2017/05/22 23:00:42 Optional nit: I'd make this an enum class Optional nit: I'd make this an enum class tommycli 2017/05/23 00:31:59 Done. Show quoted text On 2017/05/22 23:00:42, Ilya Sherman wrote: > Optional nit: I'd make this an enum class Done.
	14 LOADED_FULL_PAGE_PDF_WITH_PDFIUM = 0,

	15 LOADED_EMBEDDED_PDF_WITH_PDFIUM = 1,

	16 SHOWED_DISABLED_PLUGIN_PLACEHOLDER_FOR_EMBEDDED_PDF = 2,

	17 TRIGGERED_DRIVE_BY_DOWNLOAD = 3,

	18 PDF_LOAD_STATUS_COUNT

	19 };

	20

	21 void ReportPDFLoadStatus(PDFLoadStatus status);
	Ilya Sherman 2017/05/22 23:00:42 Hmm, it looks like you're defining a function in t Hmm, it looks like you're defining a function in the global namespace. I think that's discouraged? I'm not actually 100% sure on what's preferred though -- a wrapper class, or a wrapper namespace, or neither. tommycli 2017/05/23 00:31:59 Hey, yeah... I thought the same thing... but I did Show quoted text On 2017/05/22 23:00:42, Ilya Sherman wrote: > Hmm, it looks like you're defining a function in the global namespace. I think > that's discouraged? I'm not actually 100% sure on what's preferred though -- a > wrapper class, or a wrapper namespace, or neither. Hey, yeah... I thought the same thing... but I didn't have a strong argument (other than polluting the global namespace) as to why or what I should wrap this with... I'll leave this for another reviewer to weigh in.
	22

	23 #endif // CHROME_COMMON_PDF_UMA_H_

OLD	NEW

« no previous file with comments | « chrome/common/BUILD.gn ('k') | chrome/common/pdf_uma.cc » ('j') | no next file with comments »