Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Issue 2901543002: [ABANDONED] Revert of Update merge_pgc_files.py in preparation for VS2017 (Closed)

Created:
3 years, 7 months ago by Sébastien Marchand
Modified:
3 years, 7 months ago
Reviewers:
brucedawson, scottmg
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Update merge_pgc_files.py in preparation for VS2017 (patchset #7 id:120001 of https://codereview.chromium.org/2884613003/ ) Reason for revert: I think that it's causing crbug.com/724921 , I'll investigate but this should probably be reverted in the meantime. BUG=724921 Original issue's description: > Update merge_pgc_files.py in preparation for VS2017 > > pgomgr.exe has been moved to a different location in VS2017 so the logic > that find it should be updated. > > It can't just be copied to the build directory because we always run the > x64 bit version of this binary (and we don't want to mix x86 and x64 > binaries in the same build dir) > > BUG=719319 > > Review-Url: https://codereview.chromium.org/2884613003 > Cr-Commit-Position: refs/heads/master@{#473438} > Committed: https://chromium.googlesource.com/chromium/src/+/ab3a1821bb57a51d11be2b038b3a698236ccd5fc TBR=brucedawson@chromium.org,scottmg@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=719319

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -34 lines) Patch
M build/vs_toolchain.py View 2 chunks +14 lines, -23 lines 0 comments Download
M build/win/merge_pgc_files.py View 2 chunks +1 line, -11 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Sébastien Marchand
Created Revert of Update merge_pgc_files.py in preparation for VS2017
3 years, 7 months ago (2017-05-22 15:06:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2901543002/1
3 years, 7 months ago (2017-05-22 15:07:01 UTC) #3
Sébastien Marchand
3 years, 7 months ago (2017-05-22 15:10:11 UTC) #5
Aborting this revert, crbug.com/724921 has first been observed in 60.0.3105.0
but this has landed in 60.0.3107.0 (2 builds later).

Powered by Google App Engine
This is Rietveld 408576698