Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Unified Diff: pkg/kernel/binary.md

Issue 2901533002: [kernel] Stream everything. Replace .kernel_function with .kernel_offset (Closed)
Patch Set: Fixed assert issues; small refactorings. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/kernel/lib/binary/ast_from_binary.dart » ('j') | runtime/vm/kernel_to_il.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/kernel/binary.md
diff --git a/pkg/kernel/binary.md b/pkg/kernel/binary.md
index 9de95fbd680806950c7573641dd0ad6c6c263738..890f23715e6f7987cf53f2707aa428bc8f56fe4e 100644
--- a/pkg/kernel/binary.md
+++ b/pkg/kernel/binary.md
@@ -317,6 +317,7 @@ type FunctionNode {
Byte dartAsyncMarker; // Index into AsyncMarker above.
List<TypeParameter> typeParameters;
UInt requiredParameterCount;
+ UInt totalParameterCount; // positionalParameters.length + namedParameters.length.
Kevin Millikin (Google) 2017/06/12 12:01:51 For some reason it seems more obvious to have the
jensj 2017/06/13 13:42:14 Done.
List<VariableDeclaration> positionalParameters;
List<VariableDeclaration> namedParameters;
DartType returnType;
« no previous file with comments | « no previous file | pkg/kernel/lib/binary/ast_from_binary.dart » ('j') | runtime/vm/kernel_to_il.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698