[kernel] Stream everything. Replace .kernel_function with .kernel_offset

[kernel] Stream everything. Replace .kernel_function with .kernel_offset

- Put pointer to kernel data into Script.
- Replace function.kernel_function pointer to AstNode with
  kernel_offset():
- Replace field.kernel_field pointer to AstNode with kernel_offest().
- Stream the previously unstreamed AstNodes: FunctionDeclaration and
  FunctionExpression.
- Move special handling for _buildin.getMainClosure into the streaming
  flowgraph builder.
- Delete big parts of kernel_to_il.

R=kmillikin@google.com

Committed: https://github.com/dart-lang/sdk/commit/948e2f5d7916032ed6f0bfdc316ba4f577a5ea61
Committed: https://github.com/dart-lang/sdk/commit/4bbda48a7cbfc727e4b274acd2c124f3480df8ce

[jensj, 2017-05-22 12:05:02]

jensj@google.com changed reviewers:
+ kmillikin@google.com

[Kevin Millikin (Google), 2017-06-12 12:01:51]

It's a little strange that we use -1 as an explicit "no kernel offset" but the
code checks against offset > 0.  I'd tighten it up by, for instance, using -1
and checking against >= 0).

LGTM.

https://codereview.chromium.org/2901533002/diff/20001/pkg/kernel/binary.md
File pkg/kernel/binary.md (right):

https://codereview.chromium.org/2901533002/diff/20001/pkg/kernel/binary.md#ne...
pkg/kernel/binary.md:320: UInt totalParameterCount; //
positionalParameters.length + namedParameters.length.
For some reason it seems more obvious to have the parameter count before the
required parameter count.  And I'd just call it 'parameterCount' which seems to
obviously include all the parameters.

https://codereview.chromium.org/2901533002/diff/20001/runtime/vm/kernel_to_il.cc
File runtime/vm/kernel_to_il.cc (right):

https://codereview.chromium.org/2901533002/diff/20001/runtime/vm/kernel_to_il...
runtime/vm/kernel_to_il.cc:2660: // TODO(jensj)
TODO what?

https://codereview.chromium.org/2901533002/diff/20001/runtime/vm/kernel_to_il...
runtime/vm/kernel_to_il.cc:2688: // TODO(jensj)
TODO what?

[jensj, 2017-06-13 13:42:15]

Comments addressed. Rebased. Will likely land tomorrow morning.

https://codereview.chromium.org/2901533002/diff/20001/pkg/kernel/binary.md
File pkg/kernel/binary.md (right):

https://codereview.chromium.org/2901533002/diff/20001/pkg/kernel/binary.md#ne...
pkg/kernel/binary.md:320: UInt totalParameterCount; //
positionalParameters.length + namedParameters.length.
On 2017/06/12 12:01:51, Kevin Millikin (Google) wrote:
> For some reason it seems more obvious to have the parameter count before the
> required parameter count.  And I'd just call it 'parameterCount' which seems
to
> obviously include all the parameters.

Done.

https://codereview.chromium.org/2901533002/diff/20001/runtime/vm/kernel_to_il.cc
File runtime/vm/kernel_to_il.cc (right):

https://codereview.chromium.org/2901533002/diff/20001/runtime/vm/kernel_to_il...
runtime/vm/kernel_to_il.cc:2660: // TODO(jensj)
On 2017/06/12 12:01:51, Kevin Millikin (Google) wrote:
> TODO what?

(as below)

https://codereview.chromium.org/2901533002/diff/20001/runtime/vm/kernel_to_il...
runtime/vm/kernel_to_il.cc:2688: // TODO(jensj)
On 2017/06/12 12:01:51, Kevin Millikin (Google) wrote:
> TODO what?

Should have been
```
 // TODO(jensj): Delete this todo.
```

It was a leftover from when I initially just made this return NULL.

[jensj, 2017-06-14 06:27:30]

Description was changed from

==========
[kernel] Stream everything. Replace .kernel_function with .kernel_offset

- Put pointer to kernel data into Script.
- Replace function.kernel_function pointer to AstNode with
  kernel_offset():
- Replace field.kernel_field pointer to AstNode with kernel_offest().
- Stream the previously unstreamed AstNodes: FunctionDeclaration and
  FunctionExpression.
- Move special handling for _buildin.getMainClosure into the streaming
  flowgraph builder.
- Delete big parts of kernel_to_il.
==========

to

==========
[kernel] Stream everything. Replace .kernel_function with .kernel_offset

- Put pointer to kernel data into Script.
- Replace function.kernel_function pointer to AstNode with
  kernel_offset():
- Replace field.kernel_field pointer to AstNode with kernel_offest().
- Stream the previously unstreamed AstNodes: FunctionDeclaration and
  FunctionExpression.
- Move special handling for _buildin.getMainClosure into the streaming
  flowgraph builder.
- Delete big parts of kernel_to_il.

R=kmillikin@google.com

Committed:
https://github.com/dart-lang/sdk/commit/948e2f5d7916032ed6f0bfdc316ba4f577a5ea61
==========

[jensj, 2017-06-14 06:27:32]

Committed patchset #3 (id:40001) manually as
948e2f5d7916032ed6f0bfdc316ba4f577a5ea61 (presubmit successful).

[jensj, 2017-06-14 08:50:39]

So the land failed (i.e. tests failed) because of a bad merge.
As the fix is to change a single "if (function.kernel_offset() <= 0)" to "if
(!UseKernelFrontEndFor(parsed_function))" I'll go ahead and re-land without a
new review.

[jensj, 2017-06-14 09:00:03]

Description was changed from

==========
[kernel] Stream everything. Replace .kernel_function with .kernel_offset

- Put pointer to kernel data into Script.
- Replace function.kernel_function pointer to AstNode with
  kernel_offset():
- Replace field.kernel_field pointer to AstNode with kernel_offest().
- Stream the previously unstreamed AstNodes: FunctionDeclaration and
  FunctionExpression.
- Move special handling for _buildin.getMainClosure into the streaming
  flowgraph builder.
- Delete big parts of kernel_to_il.

R=kmillikin@google.com

Committed:
https://github.com/dart-lang/sdk/commit/948e2f5d7916032ed6f0bfdc316ba4f577a5ea61
==========

to

==========
[kernel] Stream everything. Replace .kernel_function with .kernel_offset

- Put pointer to kernel data into Script.
- Replace function.kernel_function pointer to AstNode with
  kernel_offset():
- Replace field.kernel_field pointer to AstNode with kernel_offest().
- Stream the previously unstreamed AstNodes: FunctionDeclaration and
  FunctionExpression.
- Move special handling for _buildin.getMainClosure into the streaming
  flowgraph builder.
- Delete big parts of kernel_to_il.

R=kmillikin@google.com

Committed:
https://github.com/dart-lang/sdk/commit/948e2f5d7916032ed6f0bfdc316ba4f577a5ea61
Committed:
https://github.com/dart-lang/sdk/commit/4bbda48a7cbfc727e4b274acd2c124f3480df8ce
==========

[jensj, 2017-06-14 09:00:05]

Committed patchset #4 (id:60001) manually as
4bbda48a7cbfc727e4b274acd2c124f3480df8ce (presubmit successful).