Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 290153002: Revert of Fix selection of label having control element. (Closed)

Created:
6 years, 7 months ago by Xianzhu
Modified:
6 years, 7 months ago
Reviewers:
tkent, keishi, deepak.sa
CC:
blink-reviews, dglazkov+blink, adamk+blink_chromium.org, ojan
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Revert of Fix selection of label having control element. (https://codereview.chromium.org/258933006/) Reason for revert: Causes bug 370859 BUG=148912, 370859 TBR=keishi Original issue's description: > Fix selection of label having control element. > > Any click event on label goes to its control element. So, if > we tried to select the text inside label by dragging the mouse > or by double clicking on the text, it went to its control > element. This patch checks whether there is selection or not, > after the click is happened. If there is selection then do > nothing else continue. > > New Layout test added: > fast/forms/label/label-selection.html > > BUG=148912 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173310 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174193 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174210

Patch Set 1 #

Patch Set 2 : Resolve conflict #

Patch Set 3 : Fix bad conflict resolution #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -46 lines) Patch
D LayoutTests/fast/forms/label/label-selection.html View 1 1 chunk +0 lines, -29 lines 0 comments Download
D LayoutTests/fast/forms/label/label-selection-expected.txt View 1 1 chunk +0 lines, -10 lines 0 comments Download
M Source/core/html/HTMLLabelElement.cpp View 1 2 2 chunks +0 lines, -7 lines 0 comments Download

Messages

Total messages: 18 (0 generated)
Xianzhu
Created Revert of Fix selection of label having control element.
6 years, 7 months ago (2014-05-16 17:10:25 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/290153002/1
6 years, 7 months ago (2014-05-16 17:10:50 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-16 17:10:51 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 7 months ago (2014-05-16 17:10:51 UTC) #4
Xianzhu
The CQ bit was checked by wangxianzhu@chromium.org
6 years, 7 months ago (2014-05-16 17:11:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/290153002/1
6 years, 7 months ago (2014-05-16 17:12:26 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-16 17:12:32 UTC) #7
commit-bot: I haz the power
Failed to apply patch for Source/core/html/HTMLLabelElement.cpp: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 7 months ago (2014-05-16 17:12:33 UTC) #8
Xianzhu
The CQ bit was checked by wangxianzhu@chromium.org
6 years, 7 months ago (2014-05-16 17:16:40 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/290153002/70001
6 years, 7 months ago (2014-05-16 17:16:55 UTC) #10
Xianzhu
Committed patchset #2 manually as r174193 (presubmit successful).
6 years, 7 months ago (2014-05-16 17:44:28 UTC) #11
Xianzhu
A revert of this CL has been created in https://codereview.chromium.org/282343005/ by wangxianzhu@chromium.org. The reason for ...
6 years, 7 months ago (2014-05-16 19:08:11 UTC) #12
Xianzhu
The CQ bit was checked by wangxianzhu@chromium.org
6 years, 7 months ago (2014-05-16 19:14:09 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/290153002/90001
6 years, 7 months ago (2014-05-16 19:14:24 UTC) #14
Xianzhu
Committed patchset #3 manually as r174210 (presubmit successful).
6 years, 7 months ago (2014-05-16 21:11:30 UTC) #15
tkent
not lgtm. I don't think we should revert it.
6 years, 7 months ago (2014-05-18 23:43:03 UTC) #16
Xianzhu
On 2014/05/18 23:43:03, tkent wrote: > not lgtm. > I don't think we should revert ...
6 years, 7 months ago (2014-05-19 16:03:17 UTC) #17
Xianzhu
6 years, 7 months ago (2014-05-19 17:05:51 UTC) #18
Message was sent while issue was closed.
On 2014/05/19 16:03:17, Xianzhu wrote:
> On 2014/05/18 23:43:03, tkent wrote:
> > not lgtm.
> > I don't think we should revert it.
> 
> It caused bad regression, so I thought we should revert it first before we
have
> a better solution.

Sorry, just found my previous test was inaccurate. Will reapply the original
patch (https://codereview.chromium.org/282343005/).

Powered by Google App Engine
This is Rietveld 408576698