Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issue 2901513002: Reland: Replace AudioFifo with a deque of AudioBus in ATR::AudioEncoder

Created:
3 years, 7 months ago by Chandan
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org, emircan+watch+mediarecorder_chromium.org, mcasas+mediarecorder_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland: Replace AudioFifo with a deque of AudioBus in ATR::AudioEncoder Link to original CL: https://codereview.chromium.org/2854363002/ Original CL description: This CL uses a std::deque<std::unique_ptr<media::AudioBus>> instead of an AudioFifo, to avoid copying data needlessly. The original CL was reverted due to failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzhlM2YwOTY3OGZkMjE5OTY0OWZkZmRlMWJiOWNjMGVjNTUyNDAzMDkM This reland CL zeroes out all channels of incoming audio bus. BUG=724448

Patch Set 1 #

Patch Set 2 : ATRDeque #

Patch Set 3 : ATRDeque #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -13 lines) Patch
M content/renderer/media_recorder/audio_track_recorder.cc View 1 2 9 chunks +26 lines, -13 lines 0 comments Download

Messages

Total messages: 5 (5 generated)
Chandan
The CQ bit was checked by c.padhi@samsung.com to run a CQ dry run
3 years, 7 months ago (2017-05-22 13:07:16 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2901513002/40001
3 years, 7 months ago (2017-05-22 13:07:25 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-22 14:47:44 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
3 years, 7 months ago (2017-05-22 14:47:45 UTC) #4
Chandan
3 years, 7 months ago (2017-05-23 11:30:12 UTC) #5
Description was changed from

==========
ATRDeque

BUG=
==========

to

==========
Reland: Replace AudioFifo with a deque of AudioBus in ATR::AudioEncoder

Link to original CL: https://codereview.chromium.org/2854363002/

Original CL description:
This CL uses a std::deque<std::unique_ptr<media::AudioBus>> instead
of an AudioFifo, to avoid copying data needlessly.

The original CL was reverted due to failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...

This reland CL zeroes out all channels of incoming audio bus.

BUG=724448
==========

Powered by Google App Engine
This is Rietveld 408576698