Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(699)

Unified Diff: third_party/WebKit/Source/core/loader/WorkerFetchContext.cpp

Issue 2901503002: Remove unsuitable TODO comments in WorkerFetchContext (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/loader/WorkerFetchContext.cpp
diff --git a/third_party/WebKit/Source/core/loader/WorkerFetchContext.cpp b/third_party/WebKit/Source/core/loader/WorkerFetchContext.cpp
index 9f21b6665a3165a2db2e9d5eefa2935a9790a0b4..518bc890877eba590148156c8318d102716f4158 100644
--- a/third_party/WebKit/Source/core/loader/WorkerFetchContext.cpp
+++ b/third_party/WebKit/Source/core/loader/WorkerFetchContext.cpp
@@ -116,7 +116,10 @@ SubresourceFilter* WorkerFetchContext::GetSubresourceFilter() const {
}
SecurityContext* WorkerFetchContext::GetParentSecurityContext() const {
- // TODO(horo): Implement this.
+ // This method was introduced to check the parent frame's security context
+ // while loading iframe document resources. So this method is not suitable for
+ // workers.
+ NOTREACHED();
return nullptr;
}
@@ -134,11 +137,14 @@ void WorkerFetchContext::DispatchDidBlockRequest(
}
void WorkerFetchContext::ReportLocalLoadFailed(const KURL&) const {
- // TODO(horo): Implement this.
+ // Threre is no way to load local files from worker thread.
+ NOTREACHED();
}
bool WorkerFetchContext::ShouldBypassMainWorldCSP() const {
- // TODO(horo): Implement this.
+ // This method was introduced to bypass the page's CSP while running the
+ // script from an isolated world (ex: Chrome extensions). But worker threads
+ // doesn't have any isolated world. So we can just return false.
return false;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698