Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(841)

Unified Diff: third_party/WebKit/Source/core/exported/WebPluginContainerBase.h

Issue 2901453002: Move PreFinalizer to WebPluginContainerImpl. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/exported/WebPluginContainerBase.h
diff --git a/third_party/WebKit/Source/core/exported/WebPluginContainerBase.h b/third_party/WebKit/Source/core/exported/WebPluginContainerBase.h
index 483fa54513a2a33de23d1e390737b75a64d3572d..2279512be0d238ad2b8ff329d1f0b6d1b923ab1e 100644
--- a/third_party/WebKit/Source/core/exported/WebPluginContainerBase.h
+++ b/third_party/WebKit/Source/core/exported/WebPluginContainerBase.h
@@ -32,7 +32,6 @@ class CORE_EXPORT WebPluginContainerBase
NON_EXPORTED_BASE(public WebPluginContainer),
public ContextClient {
USING_GARBAGE_COLLECTED_MIXIN(WebPluginContainerBase);
- USING_PRE_FINALIZER(WebPluginContainerBase, DispatchDispose);
public:
virtual int PrintBegin(const WebPrintParams&) const = 0;
@@ -52,9 +51,6 @@ class CORE_EXPORT WebPluginContainerBase
IntRect& unobscured_rect) = 0;
DECLARE_VIRTUAL_TRACE();
- // USING_PRE_FINALIZER does not allow for virtual dispatch from the finalizer
- // method. Here we call Dispose() which does the correct virtual dispatch.
- void DispatchDispose() { Dispose(); }
protected:
explicit WebPluginContainerBase(LocalFrame*);

Powered by Google App Engine
This is Rietveld 408576698