Linux sandbox: add more baseline policy unittests.

Linux sandbox: add more baseline policy unittests.

Add more unit tests to the baseline policy.

This is still highly incomplete.

BUG=368092
TBR=mdempsky
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271226

[jln (very slow on Chromium), 2014-05-17 00:49:07]

Matthew, could you PTAL?

I did this in a rush to at least have some basic testing in place while the MIPS
guys try to land their stuff.

[mdempsky, 2014-05-17 00:59:43]

lgtm with nits

https://codereview.chromium.org/290143006/diff/20001/sandbox/linux/seccomp-bp...
File sandbox/linux/seccomp-bpf-helpers/baseline_policy_unittest.cc (right):

https://codereview.chromium.org/290143006/diff/20001/sandbox/linux/seccomp-bp...
sandbox/linux/seccomp-bpf-helpers/baseline_policy_unittest.cc:73:
BPF_ASSERT_EQ(0, bcmp(kTestString, read_buf, kTestTransferSize));
s/bcmp/memcmp/ and #include <string.h> (bcmp was removed from POSIX 2008)

https://codereview.chromium.org/290143006/diff/20001/sandbox/linux/seccomp-bp...
sandbox/linux/seccomp-bpf-helpers/baseline_policy_unittest.cc:157: kill(1,
SIGCONT);
I assume you picked SIGCONT because it won't do anything (unless the process is
suspended), in which case you might be interested in knowing that POSIX
guarantees sending 0 as the signum will do permission checking to see if you
could send the signal, but won't actually attempt delivering any signals.  Up to
you if you want to make use of that or not.

[jln (very slow on Chromium), 2014-05-17 01:29:46]

https://chromiumcodereview.appspot.com/290143006/diff/20001/sandbox/linux/sec...
File sandbox/linux/seccomp-bpf-helpers/baseline_policy_unittest.cc (right):

https://chromiumcodereview.appspot.com/290143006/diff/20001/sandbox/linux/sec...
sandbox/linux/seccomp-bpf-helpers/baseline_policy_unittest.cc:73:
BPF_ASSERT_EQ(0, bcmp(kTestString, read_buf, kTestTransferSize));
On 2014/05/17 00:59:43, mdempsky wrote:
> s/bcmp/memcmp/ and #include <string.h> (bcmp was removed from POSIX 2008)

Done.

https://chromiumcodereview.appspot.com/290143006/diff/20001/sandbox/linux/sec...
sandbox/linux/seccomp-bpf-helpers/baseline_policy_unittest.cc:157: kill(1,
SIGCONT);
On 2014/05/17 00:59:43, mdempsky wrote:
> I assume you picked SIGCONT because it won't do anything (unless the process
is
> suspended), in which case you might be interested in knowing that POSIX
> guarantees sending 0 as the signum will do permission checking to see if you
> could send the signal, but won't actually attempt delivering any signals.  Up
to
> you if you want to make use of that or not.

Done.

[mdempsky, 2014-05-17 06:17:09]

lgtm

[jln (very slow on Chromium), 2014-05-17 07:57:33]

The CQ bit was checked by jln@chromium.org

[commit-bot: I haz the power, 2014-05-17 07:58:56]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jln@chromium.org/290143006/40001

[commit-bot: I haz the power, 2014-05-17 07:58:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-17 07:58:57]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[jln (very slow on Chromium), 2014-05-17 08:00:18]

On 2014/05/17 07:58:57, I haz the power (commit-bot) wrote:
> No LGTM from a valid reviewer yet. Only full committers are accepted.
> Even if an LGTM may have been provided, it was from a non-committer or
> a provisional committer, _not_ a full super star committer.
> See http://www.chromium.org/getting-involved/become-a-committer
> Note that this has nothing to do with OWNERS files.

Hmm, what's up with that? Something is broken here. I'll TBR for now.

[jln (very slow on Chromium), 2014-05-17 08:01:05]

The CQ bit was checked by jln@chromium.org

[commit-bot: I haz the power, 2014-05-17 08:02:26]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jln@chromium.org/290143006/40001

[jln (very slow on Chromium), 2014-05-17 16:34:36]

The CQ bit was unchecked by jln@chromium.org

[jln (very slow on Chromium), 2014-05-17 16:34:42]

The CQ bit was checked by jln@chromium.org

[commit-bot: I haz the power, 2014-05-17 16:35:17]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jln@chromium.org/290143006/40001

[commit-bot: I haz the power, 2014-05-17 16:37:02]

Change committed as 271226